Repository navigation
Gate cluster-name resolution behind KubernetesMode - #2259
Merged
Merged
Conversation
Paamicky
marked this pull request as ready for review
August 26, 2026 21:19
Paamicky
added
the
ready for testing
Paamicky
force-pushed
the
mcommey/ec2describe-fix
branch
from
August 26, 2026 22:01
ec23921 to
8a4d05d
Compare
jefchien
reviewed
Aug 26, 2026
Contributor
Binary Size Reportlinux/amd64
Notable changes:
linux/arm64
windows/amd64
Investigating size changesUse go-size-analyzer to compare binaries: GOEXPERIMENT=jsonv2 go install github.com/Zxilly/go-size-analyzer/cmd/gsa@latest
gsa diff --old <baseline-binary> --new <new-binary> |
Paamicky
force-pushed
the
mcommey/ec2describe-fix
branch
from
August 27, 2026 14:20
9dd81fa to
12a977b
Compare
jefchien
approved these changes
Aug 27, 2026
EduVencovsky
approved these changes
Aug 28, 2026
sky333999
added a commit
that referenced
this pull request
Sep 3, 2026
Adapts the self-telemetry (#2246) and GCE/GKE (#2255, #2258, #2259) features to the v0.150 collector APIs and fork components: - self-telemetry: v0.150 moves service telemetry config behind component.Config (concrete type in service/telemetry/otelconftelemetry), so tests assert the concrete config before reading its fields; the two self-telemetry goldens pick up the v0.150 telemetry shape. - resourcedetection: set ignore_detector_errors on gcp_config.yaml so the GCP detector degrades instead of aborting startup, matching the other five embedded configs (TestAllEmbeddedConfigsIgnoreDetectorErrors enforces this) and update the GCP test expectations accordingly. - migrate the EC2 tag test stubs to the aws-sdk-go-v2 DescribeTagsAPIClient signature. - extension/selftelemetry: otelprom WithoutCounterSuffixes/WithoutUnits are deprecated as of the exporter version in this cohort; keep them (the replacement WithTranslationStrategy also changes metric name escaping) with nolint until they are migrated deliberately. - regenerate the Container Insights (#2249, #2250) and GCE (#2260) goldens for v0.150 defaults, and drop a duplicated skip_replicaset_watch key.
sky333999
added a commit
that referenced
this pull request
Sep 3, 2026
Adapts the self-telemetry (#2246) and GCE/GKE (#2255, #2258, #2259) features to the v0.150 collector APIs and fork components: - self-telemetry: v0.150 moves service telemetry config behind component.Config (concrete type in service/telemetry/otelconftelemetry), so tests assert the concrete config before reading its fields; the two self-telemetry goldens pick up the v0.150 telemetry shape. - resourcedetection: set ignore_detector_errors on gcp_config.yaml so the GCP detector degrades instead of aborting startup, matching the other five embedded configs (TestAllEmbeddedConfigsIgnoreDetectorErrors enforces this) and update the GCP test expectations accordingly. - migrate the EC2 tag test stubs to the aws-sdk-go-v2 DescribeTagsAPIClient signature. - extension/selftelemetry: otelprom WithoutCounterSuffixes/WithoutUnits are deprecated as of the exporter version in this cohort; keep them (the replacement WithTranslationStrategy also changes metric name escaping) with nolint until they are migrated deliberately. - regenerate the Container Insights (#2249, #2250) and GCE (#2260) goldens for v0.150 defaults, and drop a duplicated skip_replicaset_watch key.
sky333999
added a commit
that referenced
this pull request
Sep 16, 2026
Adapts the self-telemetry (#2246) and GCE/GKE (#2255, #2258, #2259) features to the v0.150 collector APIs and fork components: - self-telemetry: v0.150 moves service telemetry config behind component.Config (concrete type in service/telemetry/otelconftelemetry), so tests assert the concrete config before reading its fields; the two self-telemetry goldens pick up the v0.150 telemetry shape. - resourcedetection: set ignore_detector_errors on gcp_config.yaml so the GCP detector degrades instead of aborting startup, matching the other five embedded configs (TestAllEmbeddedConfigsIgnoreDetectorErrors enforces this) and update the GCP test expectations accordingly. - migrate the EC2 tag test stubs to the aws-sdk-go-v2 DescribeTagsAPIClient signature. - extension/selftelemetry: otelprom WithoutCounterSuffixes/WithoutUnits are deprecated as of the exporter version in this cohort; keep them (the replacement WithTranslationStrategy also changes metric name escaping) with nolint until they are migrated deliberately. - regenerate the Container Insights (#2249, #2250) and GCE (#2260) goldens for v0.150 defaults, and drop a duplicated skip_replicaset_watch key.
sky333999
added a commit
that referenced
this pull request
Sep 18, 2026
Adapts the self-telemetry (#2246) and GCE/GKE (#2255, #2258, #2259) features to the v0.150 collector APIs and fork components: - self-telemetry: v0.150 moves service telemetry config behind component.Config (concrete type in service/telemetry/otelconftelemetry), so tests assert the concrete config before reading its fields; the two self-telemetry goldens pick up the v0.150 telemetry shape. - resourcedetection: set ignore_detector_errors on gcp_config.yaml so the GCP detector degrades instead of aborting startup, matching the other five embedded configs (TestAllEmbeddedConfigsIgnoreDetectorErrors enforces this) and update the GCP test expectations accordingly. - migrate the EC2 tag test stubs to the aws-sdk-go-v2 DescribeTagsAPIClient signature. - extension/selftelemetry: otelprom WithoutCounterSuffixes/WithoutUnits are deprecated as of the exporter version in this cohort; keep them (the replacement WithTranslationStrategy also changes metric name escaping) with nolint until they are migrated deliberately. - regenerate the Container Insights (#2249, #2250) and GCE (#2260) goldens for v0.150 defaults, and drop a duplicated skip_replicaset_watch key.
sky333999
added a commit
that referenced
this pull request
Sep 18, 2026
Adapts the self-telemetry (#2246) and GCE/GKE (#2255, #2258, #2259) features to the v0.150 collector APIs and fork components: - self-telemetry: v0.150 moves service telemetry config behind component.Config (concrete type in service/telemetry/otelconftelemetry), so tests assert the concrete config before reading its fields; the two self-telemetry goldens pick up the v0.150 telemetry shape. - resourcedetection: set ignore_detector_errors on gcp_config.yaml so the GCP detector degrades instead of aborting startup, matching the other five embedded configs (TestAllEmbeddedConfigsIgnoreDetectorErrors enforces this) and update the GCP test expectations accordingly. - migrate the EC2 tag test stubs to the aws-sdk-go-v2 DescribeTagsAPIClient signature. - extension/selftelemetry: otelprom WithoutCounterSuffixes/WithoutUnits are deprecated as of the exporter version in this cohort; keep them (the replacement WithTranslationStrategy also changes metric name escaping) with nolint until they are migrated deliberately. - regenerate the Container Insights (#2249, #2250) and GCE (#2260) goldens for v0.150 defaults, and drop a duplicated skip_replicaset_watch key.
sky333999
added a commit
that referenced
this pull request
Sep 21, 2026
Adapts the self-telemetry (#2246) and GCE/GKE (#2255, #2258, #2259) features to the v0.150 collector APIs and fork components: - self-telemetry: v0.150 moves service telemetry config behind component.Config (concrete type in service/telemetry/otelconftelemetry), so tests assert the concrete config before reading its fields; the two self-telemetry goldens pick up the v0.150 telemetry shape. - resourcedetection: set ignore_detector_errors on gcp_config.yaml so the GCP detector degrades instead of aborting startup, matching the other five embedded configs (TestAllEmbeddedConfigsIgnoreDetectorErrors enforces this) and update the GCP test expectations accordingly. - migrate the EC2 tag test stubs to the aws-sdk-go-v2 DescribeTagsAPIClient signature. - extension/selftelemetry: otelprom WithoutCounterSuffixes/WithoutUnits are deprecated as of the exporter version in this cohort; keep them (the replacement WithTranslationStrategy also changes metric name escaping) with nolint until they are migrated deliberately. - regenerate the Container Insights (#2249, #2250) and GCE (#2260) goldens for v0.150 defaults, and drop a duplicated skip_replicaset_watch key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
When the agent can't reach the EC2 API (e.g. a private VPC), starting it with an OpenTelemetry config hangs. The agent calls EC2 for instance tags to resolve a cluster name on non-Kubernetes hosts, and that call retries until config setup stalls.
Description of changes
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
TestClusterNameSkippedNonK8swhich assertsset_cluster_nameis absent whenKubernetesMode=""and updated existing cluster-name test to run under EKS mode. Regenerated 2 goldens.Requirements
make fmtandmake fmt-shmake lint