Repository navigation
Fix CWAgent container insights - #2249
Merged
Merged
Conversation
Paamicky
force-pushed
the
mcommey/OtelContainerInsight
branch
from
August 17, 2026 19:08
aa5093b to
4be3af9
Compare
Paamicky
marked this pull request as ready for review
August 17, 2026 19:08
Paamicky
force-pushed
the
mcommey/OtelContainerInsight
branch
from
August 17, 2026 20:05
bae8c04 to
452caf0
Compare
Paamicky
force-pushed
the
mcommey/OtelContainerInsight
branch
from
August 17, 2026 20:18
452caf0 to
a0cb8bf
Compare
Contributor
Binary Size Reportlinux/amd64
Notable changes:
linux/arm64
windows/amd64
Investigating size changesUse go-size-analyzer to compare binaries: GOEXPERIMENT=jsonv2 go install github.com/Zxilly/go-size-analyzer/cmd/gsa@latest
gsa diff --old <baseline-binary> --new <new-binary> |
Paamicky
force-pushed
the
mcommey/OtelContainerInsight
branch
from
August 18, 2026 15:38
839d539 to
0fe7082
Compare
Paamicky
force-pushed
the
mcommey/OtelContainerInsight
branch
from
August 18, 2026 19:14
0fe7082 to
553469b
Compare
sky333999
reviewed
Aug 19, 2026
sky333999
approved these changes
Aug 20, 2026
movence
approved these changes
Aug 20, 2026
sky333999
added a commit
that referenced
this pull request
Sep 3, 2026
Adapts the self-telemetry (#2246) and GCE/GKE (#2255, #2258, #2259) features to the v0.150 collector APIs and fork components: - self-telemetry: v0.150 moves service telemetry config behind component.Config (concrete type in service/telemetry/otelconftelemetry), so tests assert the concrete config before reading its fields; the two self-telemetry goldens pick up the v0.150 telemetry shape. - resourcedetection: set ignore_detector_errors on gcp_config.yaml so the GCP detector degrades instead of aborting startup, matching the other five embedded configs (TestAllEmbeddedConfigsIgnoreDetectorErrors enforces this) and update the GCP test expectations accordingly. - migrate the EC2 tag test stubs to the aws-sdk-go-v2 DescribeTagsAPIClient signature. - extension/selftelemetry: otelprom WithoutCounterSuffixes/WithoutUnits are deprecated as of the exporter version in this cohort; keep them (the replacement WithTranslationStrategy also changes metric name escaping) with nolint until they are migrated deliberately. - regenerate the Container Insights (#2249, #2250) and GCE (#2260) goldens for v0.150 defaults, and drop a duplicated skip_replicaset_watch key.
sky333999
added a commit
that referenced
this pull request
Sep 3, 2026
Adapts the self-telemetry (#2246) and GCE/GKE (#2255, #2258, #2259) features to the v0.150 collector APIs and fork components: - self-telemetry: v0.150 moves service telemetry config behind component.Config (concrete type in service/telemetry/otelconftelemetry), so tests assert the concrete config before reading its fields; the two self-telemetry goldens pick up the v0.150 telemetry shape. - resourcedetection: set ignore_detector_errors on gcp_config.yaml so the GCP detector degrades instead of aborting startup, matching the other five embedded configs (TestAllEmbeddedConfigsIgnoreDetectorErrors enforces this) and update the GCP test expectations accordingly. - migrate the EC2 tag test stubs to the aws-sdk-go-v2 DescribeTagsAPIClient signature. - extension/selftelemetry: otelprom WithoutCounterSuffixes/WithoutUnits are deprecated as of the exporter version in this cohort; keep them (the replacement WithTranslationStrategy also changes metric name escaping) with nolint until they are migrated deliberately. - regenerate the Container Insights (#2249, #2250) and GCE (#2260) goldens for v0.150 defaults, and drop a duplicated skip_replicaset_watch key.
sky333999
added a commit
that referenced
this pull request
Sep 16, 2026
Adapts the self-telemetry (#2246) and GCE/GKE (#2255, #2258, #2259) features to the v0.150 collector APIs and fork components: - self-telemetry: v0.150 moves service telemetry config behind component.Config (concrete type in service/telemetry/otelconftelemetry), so tests assert the concrete config before reading its fields; the two self-telemetry goldens pick up the v0.150 telemetry shape. - resourcedetection: set ignore_detector_errors on gcp_config.yaml so the GCP detector degrades instead of aborting startup, matching the other five embedded configs (TestAllEmbeddedConfigsIgnoreDetectorErrors enforces this) and update the GCP test expectations accordingly. - migrate the EC2 tag test stubs to the aws-sdk-go-v2 DescribeTagsAPIClient signature. - extension/selftelemetry: otelprom WithoutCounterSuffixes/WithoutUnits are deprecated as of the exporter version in this cohort; keep them (the replacement WithTranslationStrategy also changes metric name escaping) with nolint until they are migrated deliberately. - regenerate the Container Insights (#2249, #2250) and GCE (#2260) goldens for v0.150 defaults, and drop a duplicated skip_replicaset_watch key.
sky333999
added a commit
that referenced
this pull request
Sep 18, 2026
Adapts the self-telemetry (#2246) and GCE/GKE (#2255, #2258, #2259) features to the v0.150 collector APIs and fork components: - self-telemetry: v0.150 moves service telemetry config behind component.Config (concrete type in service/telemetry/otelconftelemetry), so tests assert the concrete config before reading its fields; the two self-telemetry goldens pick up the v0.150 telemetry shape. - resourcedetection: set ignore_detector_errors on gcp_config.yaml so the GCP detector degrades instead of aborting startup, matching the other five embedded configs (TestAllEmbeddedConfigsIgnoreDetectorErrors enforces this) and update the GCP test expectations accordingly. - migrate the EC2 tag test stubs to the aws-sdk-go-v2 DescribeTagsAPIClient signature. - extension/selftelemetry: otelprom WithoutCounterSuffixes/WithoutUnits are deprecated as of the exporter version in this cohort; keep them (the replacement WithTranslationStrategy also changes metric name escaping) with nolint until they are migrated deliberately. - regenerate the Container Insights (#2249, #2250) and GCE (#2260) goldens for v0.150 defaults, and drop a duplicated skip_replicaset_watch key.
sky333999
added a commit
that referenced
this pull request
Sep 18, 2026
Adapts the self-telemetry (#2246) and GCE/GKE (#2255, #2258, #2259) features to the v0.150 collector APIs and fork components: - self-telemetry: v0.150 moves service telemetry config behind component.Config (concrete type in service/telemetry/otelconftelemetry), so tests assert the concrete config before reading its fields; the two self-telemetry goldens pick up the v0.150 telemetry shape. - resourcedetection: set ignore_detector_errors on gcp_config.yaml so the GCP detector degrades instead of aborting startup, matching the other five embedded configs (TestAllEmbeddedConfigsIgnoreDetectorErrors enforces this) and update the GCP test expectations accordingly. - migrate the EC2 tag test stubs to the aws-sdk-go-v2 DescribeTagsAPIClient signature. - extension/selftelemetry: otelprom WithoutCounterSuffixes/WithoutUnits are deprecated as of the exporter version in this cohort; keep them (the replacement WithTranslationStrategy also changes metric name escaping) with nolint until they are migrated deliberately. - regenerate the Container Insights (#2249, #2250) and GCE (#2260) goldens for v0.150 defaults, and drop a duplicated skip_replicaset_watch key.
sky333999
added a commit
that referenced
this pull request
Sep 21, 2026
Adapts the self-telemetry (#2246) and GCE/GKE (#2255, #2258, #2259) features to the v0.150 collector APIs and fork components: - self-telemetry: v0.150 moves service telemetry config behind component.Config (concrete type in service/telemetry/otelconftelemetry), so tests assert the concrete config before reading its fields; the two self-telemetry goldens pick up the v0.150 telemetry shape. - resourcedetection: set ignore_detector_errors on gcp_config.yaml so the GCP detector degrades instead of aborting startup, matching the other five embedded configs (TestAllEmbeddedConfigsIgnoreDetectorErrors enforces this) and update the GCP test expectations accordingly. - migrate the EC2 tag test stubs to the aws-sdk-go-v2 DescribeTagsAPIClient signature. - extension/selftelemetry: otelprom WithoutCounterSuffixes/WithoutUnits are deprecated as of the exporter version in this cohort; keep them (the replacement WithTranslationStrategy also changes metric name escaping) with nolint until they are migrated deliberately. - regenerate the Container Insights (#2249, #2250) and GCE (#2260) goldens for v0.150 defaults, and drop a duplicated skip_replicaset_watch key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
While bringing OTEL Container Insights (OCI) into the CloudWatch Agent, several pieces of functionality present in the Helm implementation were dropped or omitted, leaving the agent-generated config diverged from the chart. Most notably: OCI logs were never delivered to CloudWatch Logs because the
log-group/log-streammetadata was missing; cluster-scoped metrics (apiserver, kube-state-metrics) carried the scraper node's identity. Attributes limits of <150 guaranteed to the Zeus endpoint was broken as well as Batching.Description of changes
Realigns the agent's OTEL Container Insights pipelines with the Helm implementation and fixes the dropped/omitted functionality:
service.name/deployment.environment.name).resourcedetection/opentelemetry) and remove the redundant per-CI-pipeline clears.host.*, cloud.availability_zone, and ec2.tag.*so series stay stable across scraper reschedules.awsattributelimit(150-cap) on the shared metrics pipeline to stay under the CloudWatch OTLP backend limit.1000/10swhich affects all OTLP metricsAll changes are gated to EKS OTEL Container Insights; ECS, host metrics, and non-CI pipelines are unaffected. Goldens regenerated.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
Requirements