Repository navigation
Add KEDA and Karpenter metrics scrapping to CWAgent - #2250
Merged
Merged
Conversation
Paamicky
marked this pull request as ready for review
August 17, 2026 19:47
Paamicky
force-pushed
the
mcommey/CI-keda-kapernter
branch
from
August 19, 2026 14:11
6b39d69 to
2599868
Compare
sky333999
reviewed
Aug 19, 2026
Paamicky
force-pushed
the
mcommey/CI-keda-kapernter
branch
2 times, most recently
from
August 20, 2026 18:45
d6967d2 to
786fc17
Compare
sky333999
previously approved these changes
Aug 20, 2026
Contributor
Binary Size Reportlinux/amd64
Notable changes:
linux/arm64
windows/amd64
Investigating size changesUse go-size-analyzer to compare binaries: GOEXPERIMENT=jsonv2 go install github.com/Zxilly/go-size-analyzer/cmd/gsa@latest
gsa diff --old <baseline-binary> --new <new-binary> |
jefchien
previously approved these changes
Aug 20, 2026
| "type": "object", | ||
| "properties": { | ||
| "enabled": { | ||
| "description": "Default toggle(true) for solutions; when false, no solutions run even.", |
Contributor
There was a problem hiding this comment.
nit: Description seems incomplete. I think we're trying to say that this takes precedence over the individual solution "enabled" toggles.
Paamicky
force-pushed
the
mcommey/CI-keda-kapernter
branch
from
August 21, 2026 00:34
21283c2 to
f338b13
Compare
Paamicky
disabled auto-merge
August 21, 2026 00:53
Paamicky
force-pushed
the
mcommey/CI-keda-kapernter
branch
from
August 21, 2026 02:12
f338b13 to
1e5bc05
Compare
TravisStark
previously approved these changes
Aug 21, 2026
JayPolanco
previously approved these changes
Aug 21, 2026
JayPolanco
disabled auto-merge
August 21, 2026 14:36
JayPolanco
disabled auto-merge
August 21, 2026 14:37
Paamicky
disabled auto-merge
August 21, 2026 14:40
Paamicky
dismissed stale reviews from JayPolanco and TravisStark
August 21, 2026 15:09
The merge-base changed after approval.
sky333999
force-pushed
the
mcommey/CI-keda-kapernter
branch
from
August 21, 2026 15:09
1e5bc05 to
f9d2e34
Compare
sky333999
approved these changes
Aug 21, 2026
JayPolanco
approved these changes
Aug 21, 2026
sky333999
added a commit
that referenced
this pull request
Sep 3, 2026
Adapts the self-telemetry (#2246) and GCE/GKE (#2255, #2258, #2259) features to the v0.150 collector APIs and fork components: - self-telemetry: v0.150 moves service telemetry config behind component.Config (concrete type in service/telemetry/otelconftelemetry), so tests assert the concrete config before reading its fields; the two self-telemetry goldens pick up the v0.150 telemetry shape. - resourcedetection: set ignore_detector_errors on gcp_config.yaml so the GCP detector degrades instead of aborting startup, matching the other five embedded configs (TestAllEmbeddedConfigsIgnoreDetectorErrors enforces this) and update the GCP test expectations accordingly. - migrate the EC2 tag test stubs to the aws-sdk-go-v2 DescribeTagsAPIClient signature. - extension/selftelemetry: otelprom WithoutCounterSuffixes/WithoutUnits are deprecated as of the exporter version in this cohort; keep them (the replacement WithTranslationStrategy also changes metric name escaping) with nolint until they are migrated deliberately. - regenerate the Container Insights (#2249, #2250) and GCE (#2260) goldens for v0.150 defaults, and drop a duplicated skip_replicaset_watch key.
sky333999
added a commit
that referenced
this pull request
Sep 3, 2026
Adapts the self-telemetry (#2246) and GCE/GKE (#2255, #2258, #2259) features to the v0.150 collector APIs and fork components: - self-telemetry: v0.150 moves service telemetry config behind component.Config (concrete type in service/telemetry/otelconftelemetry), so tests assert the concrete config before reading its fields; the two self-telemetry goldens pick up the v0.150 telemetry shape. - resourcedetection: set ignore_detector_errors on gcp_config.yaml so the GCP detector degrades instead of aborting startup, matching the other five embedded configs (TestAllEmbeddedConfigsIgnoreDetectorErrors enforces this) and update the GCP test expectations accordingly. - migrate the EC2 tag test stubs to the aws-sdk-go-v2 DescribeTagsAPIClient signature. - extension/selftelemetry: otelprom WithoutCounterSuffixes/WithoutUnits are deprecated as of the exporter version in this cohort; keep them (the replacement WithTranslationStrategy also changes metric name escaping) with nolint until they are migrated deliberately. - regenerate the Container Insights (#2249, #2250) and GCE (#2260) goldens for v0.150 defaults, and drop a duplicated skip_replicaset_watch key.
sky333999
added a commit
that referenced
this pull request
Sep 16, 2026
Adapts the self-telemetry (#2246) and GCE/GKE (#2255, #2258, #2259) features to the v0.150 collector APIs and fork components: - self-telemetry: v0.150 moves service telemetry config behind component.Config (concrete type in service/telemetry/otelconftelemetry), so tests assert the concrete config before reading its fields; the two self-telemetry goldens pick up the v0.150 telemetry shape. - resourcedetection: set ignore_detector_errors on gcp_config.yaml so the GCP detector degrades instead of aborting startup, matching the other five embedded configs (TestAllEmbeddedConfigsIgnoreDetectorErrors enforces this) and update the GCP test expectations accordingly. - migrate the EC2 tag test stubs to the aws-sdk-go-v2 DescribeTagsAPIClient signature. - extension/selftelemetry: otelprom WithoutCounterSuffixes/WithoutUnits are deprecated as of the exporter version in this cohort; keep them (the replacement WithTranslationStrategy also changes metric name escaping) with nolint until they are migrated deliberately. - regenerate the Container Insights (#2249, #2250) and GCE (#2260) goldens for v0.150 defaults, and drop a duplicated skip_replicaset_watch key.
sky333999
added a commit
that referenced
this pull request
Sep 18, 2026
Adapts the self-telemetry (#2246) and GCE/GKE (#2255, #2258, #2259) features to the v0.150 collector APIs and fork components: - self-telemetry: v0.150 moves service telemetry config behind component.Config (concrete type in service/telemetry/otelconftelemetry), so tests assert the concrete config before reading its fields; the two self-telemetry goldens pick up the v0.150 telemetry shape. - resourcedetection: set ignore_detector_errors on gcp_config.yaml so the GCP detector degrades instead of aborting startup, matching the other five embedded configs (TestAllEmbeddedConfigsIgnoreDetectorErrors enforces this) and update the GCP test expectations accordingly. - migrate the EC2 tag test stubs to the aws-sdk-go-v2 DescribeTagsAPIClient signature. - extension/selftelemetry: otelprom WithoutCounterSuffixes/WithoutUnits are deprecated as of the exporter version in this cohort; keep them (the replacement WithTranslationStrategy also changes metric name escaping) with nolint until they are migrated deliberately. - regenerate the Container Insights (#2249, #2250) and GCE (#2260) goldens for v0.150 defaults, and drop a duplicated skip_replicaset_watch key.
sky333999
added a commit
that referenced
this pull request
Sep 18, 2026
Adapts the self-telemetry (#2246) and GCE/GKE (#2255, #2258, #2259) features to the v0.150 collector APIs and fork components: - self-telemetry: v0.150 moves service telemetry config behind component.Config (concrete type in service/telemetry/otelconftelemetry), so tests assert the concrete config before reading its fields; the two self-telemetry goldens pick up the v0.150 telemetry shape. - resourcedetection: set ignore_detector_errors on gcp_config.yaml so the GCP detector degrades instead of aborting startup, matching the other five embedded configs (TestAllEmbeddedConfigsIgnoreDetectorErrors enforces this) and update the GCP test expectations accordingly. - migrate the EC2 tag test stubs to the aws-sdk-go-v2 DescribeTagsAPIClient signature. - extension/selftelemetry: otelprom WithoutCounterSuffixes/WithoutUnits are deprecated as of the exporter version in this cohort; keep them (the replacement WithTranslationStrategy also changes metric name escaping) with nolint until they are migrated deliberately. - regenerate the Container Insights (#2249, #2250) and GCE (#2260) goldens for v0.150 defaults, and drop a duplicated skip_replicaset_watch key.
sky333999
added a commit
that referenced
this pull request
Sep 21, 2026
Adapts the self-telemetry (#2246) and GCE/GKE (#2255, #2258, #2259) features to the v0.150 collector APIs and fork components: - self-telemetry: v0.150 moves service telemetry config behind component.Config (concrete type in service/telemetry/otelconftelemetry), so tests assert the concrete config before reading its fields; the two self-telemetry goldens pick up the v0.150 telemetry shape. - resourcedetection: set ignore_detector_errors on gcp_config.yaml so the GCP detector degrades instead of aborting startup, matching the other five embedded configs (TestAllEmbeddedConfigsIgnoreDetectorErrors enforces this) and update the GCP test expectations accordingly. - migrate the EC2 tag test stubs to the aws-sdk-go-v2 DescribeTagsAPIClient signature. - extension/selftelemetry: otelprom WithoutCounterSuffixes/WithoutUnits are deprecated as of the exporter version in this cohort; keep them (the replacement WithTranslationStrategy also changes metric name escaping) with nolint until they are migrated deliberately. - regenerate the Container Insights (#2249, #2250) and GCE (#2260) goldens for v0.150 defaults, and drop a duplicated skip_replicaset_watch key.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
OTEL Container Insights supports now supports scrapping of KEDA and Karpenter cluster metrics in Helm Chart.
Customer should be able to configure and scrape those metrics on the CloudWatch Agent.
Description of changes
opentelemetry.collect.container_insights.solutions.{keda,karpenter}.
schema.jsonfor customersshared host/AZ/ec2.tag suppression, schema_url clear, awsattributelimit, and batching.
set_workloadto the canonical full definition so all copies are identical (avoids an order-dependent mergecollision).
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this
contribution, under the terms of your choice.
Tests
endpoints and added the scrape jobs; confirmed
keda_scaler_activeandkarpenter_nodes_totalin CloudWatch.Requirements
Integration Tests
To run integration tests against this PR, add the ready for testing label.