Repository navigation
Conversation
Member
|
What is the point of these tests? What are you trying to confirm? You're not making any assertions. You need to confirm something does/doesn't exist, has/hasn't changed, or did/didn't throw. |
rogierschouten
pushed a commit
to rogierschouten/lolex
that referenced
this pull request
May 27, 2016
fatso83
pushed a commit
to fatso83/lolex
that referenced
this pull request
Jul 13, 2016
fatso83
pushed a commit
to fatso83/lolex
that referenced
this pull request
Jul 13, 2016
fatso83
pushed a commit
to fatso83/lolex
that referenced
this pull request
Jul 13, 2016
Contributor
|
Merged in #74 (author info changed to reflect your contribution). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bear in mind that this is the way I was using lolex until revision 1.4.0, the additional test case fails for lolex 1.5.0 with nodejs 6.2.0.
Do not hesitate to comment if I am misusing lolex from the beginning.