Skip to content

fix for issue #59 - #62

Closed
rogierschouten wants to merge 3 commits into
sinonjs:masterfrom
rogierschouten:issue59
Closed

rogierschouten wants to merge 3 commits into
sinonjs:masterfrom
rogierschouten:issue59

Conversation

@rogierschouten

Copy link
Copy Markdown

No description provided.

@fatso83

fatso83 commented May 26, 2016

Copy link
Copy Markdown
Contributor

I'll hold on merging this until we can get a test case from @gautaz. Would like to avoid reintroducing it :-)

P.S. Don't checking the compiled code. That keeps the diffs smaller and easier to look through. We only update the dist when publishing a new version.

@rogierschouten

Copy link
Copy Markdown
Author

OK!
On May 26, 2016 20:32, "Carl-Erik Kopseng" notifications@github.com wrote:

I'll hold on merging this until we can get a test case from @gautaz
https://github.com/gautaz. Would like to avoid reintroducing it :-)

P.S. Don't checking the compiled code. That keeps the diffs smaller and
easier to look through. We only update the dist when publishing a new
version.

โ€”
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#62 (comment)

@rogierschouten

Copy link
Copy Markdown
Author

@fatso83 test incorporated. It failed when I undid my fix and it passes now.

@rogierschouten rogierschouten mentioned this pull request May 27, 2016
fatso83 added a commit that referenced this pull request Jul 13, 2016
@fatso83

fatso83 commented Jul 13, 2016

Copy link
Copy Markdown
Contributor

Sorry for taking this long to merge this! Had to rebase so merged as #74.

@fatso83 fatso83 closed this Jul 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants