Skip to content

Fix margin for attached top header on code review - #11571

Merged
zeripath merged 2 commits into
go-gitea:masterfrom
CirnoT:review-attached
May 25, 2020
Merged

zeripath merged 2 commits into
go-gitea:masterfrom
CirnoT:review-attached

Conversation

@CirnoT

@CirnoT CirnoT commented May 23, 2020

Copy link
Copy Markdown
Contributor

Introduced naively by #11463

The margin was being applied too widely. Fixes this:

chrome_2020-05-23_02-58-52

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 23, 2020
@zeripath zeripath added backport/v1.12 topic/ui Change the appearance of the Gitea UI labels May 24, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 24, 2020
@zeripath

Copy link
Copy Markdown
Contributor

Thanks @CirnoT

In order to reduce the delays for merging I wonder if we could try to bunch some of these styling fixes (for at least the backports.)

@zeripath
zeripath merged commit e682a92 into go-gitea:master May 25, 2020
@zeripath

Copy link
Copy Markdown
Contributor

Please send backport

@CirnoT
CirnoT deleted the review-attached branch May 25, 2020 13:39
CirnoT added a commit to CirnoT/gitea that referenced this pull request May 25, 2020
Introduced naively by go-gitea#11463

The margin was being applied too widely.

(cherry picked from commit e682a92)
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label May 25, 2020
techknowlogick pushed a commit that referenced this pull request May 26, 2020
* Fix inconsistent font size for markdown preview on new PR view (#11565)

We use same method for new issue form and issue view, but was missing from new PR view making it one place where markdown preview is inconsistent in font size.

(cherry picked from commit 04afd9d)

* Fix margin on PR form (#11566)

(cherry picked from commit f2a0be1)

* Fix margin for attached top header on code review (#11571)

Introduced naively by #11463

The margin was being applied too widely.

(cherry picked from commit e682a92)

* Fix styling for PR merge section when no checks (#11609)

Makes styling consistent between two cases. Also removed unnecessary double border.

* Normalize avatar radius
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
Introduced naively by go-gitea#11463

The margin was being applied too widely.
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants