Skip to content

Fix styling of resolved code comment box - #11463

Merged
lafriks merged 2 commits into
go-gitea:masterfrom
CirnoT:code-comment-resolved
May 17, 2020
Merged

lafriks merged 2 commits into
go-gitea:masterfrom
CirnoT:code-comment-resolved

Conversation

@CirnoT

@CirnoT CirnoT commented May 17, 2020

Copy link
Copy Markdown
Contributor

Before:
chrome_2020-05-17_20-33-43

After:
chrome_2020-05-17_20-33-20

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 17, 2020
@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label May 17, 2020
@zeripath zeripath added this to the 1.13.0 milestone May 17, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 17, 2020
@lafriks
lafriks merged commit 7fd60c6 into go-gitea:master May 17, 2020
lafriks added a commit to lafriks-fork/gitea that referenced this pull request May 17, 2020
Co-authored-by: Lauris BH <lauris@nix.lv>
@lafriks lafriks added the backport/done All backports for this PR have been created label May 17, 2020
@CirnoT
CirnoT deleted the code-comment-resolved branch May 17, 2020 20:57
zeripath pushed a commit that referenced this pull request May 18, 2020
…1467)

* Fix styling of resolved code comment box (#11463)

Co-authored-by: Lauris BH <lauris@nix.lv>

* Fix .comment-code-cloud not being removed when cancelling new code comment (#11464)

* Fix footer padding for comment code reply form on issue event view (#11469)

Co-authored-by: Cirno the Strongest <1447794+CirnoT@users.noreply.github.com>
zeripath pushed a commit that referenced this pull request May 25, 2020
Introduced naively by #11463

The margin was being applied too widely.
CirnoT added a commit to CirnoT/gitea that referenced this pull request May 25, 2020
Introduced naively by go-gitea#11463

The margin was being applied too widely.

(cherry picked from commit e682a92)
techknowlogick pushed a commit that referenced this pull request May 26, 2020
* Fix inconsistent font size for markdown preview on new PR view (#11565)

We use same method for new issue form and issue view, but was missing from new PR view making it one place where markdown preview is inconsistent in font size.

(cherry picked from commit 04afd9d)

* Fix margin on PR form (#11566)

(cherry picked from commit f2a0be1)

* Fix margin for attached top header on code review (#11571)

Introduced naively by #11463

The margin was being applied too widely.

(cherry picked from commit e682a92)

* Fix styling for PR merge section when no checks (#11609)

Makes styling consistent between two cases. Also removed unnecessary double border.

* Normalize avatar radius
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
Co-authored-by: Lauris BH <lauris@nix.lv>
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
Introduced naively by go-gitea#11463

The margin was being applied too widely.
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants