Skip to content

Make references to JDBC driver classes explicit. Fixes #7504 - #7506

Merged
tfmorris merged 1 commit into
OpenRefine:masterfrom
tfmorris:7504-database-driver-class
Oct 25, 2025
Merged

Make references to JDBC driver classes explicit. Fixes #7504#7506
tfmorris merged 1 commit into
OpenRefine:masterfrom
tfmorris:7504-database-driver-class

Conversation

@tfmorris

@tfmorris tfmorris commented Oct 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Fixes #7504

Changes proposed in this pull request:

  • Reference classes directly instead of burying them in opaque strings

@github-actions github-actions Bot added Type: Bug Issues related to software defects or unexpected behavior, which require resolution. maintainability Making it easier to maintain OpenRefine Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators SQL/database Integration with SQL databases in general labels Oct 22, 2025
@tfmorris tfmorris mentioned this pull request Oct 22, 2025
Closed
@tfmorris tfmorris removed the Status: Pending Review Indicates that the issue or pull request is awaiting review by project maintainers or collaborators label Oct 22, 2025
@tfmorris
tfmorris force-pushed the 7504-database-driver-class branch from 51207fe to 4026d96 Compare October 24, 2025 18:50
@tfmorris
tfmorris marked this pull request as ready for review October 24, 2025 18:52
@tfmorris
tfmorris requested a review from smierz October 24, 2025 18:53
@tfmorris tfmorris mentioned this pull request Oct 24, 2025
Merged
@tfmorris
tfmorris requested a review from SoryRawyer October 24, 2025 19:21
smierz
smierz approved these changes Oct 25, 2025
View reviewed changes

@smierz smierz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for future reference:
the corresponding changes in MySQLDatabaseService happened in a previous PR
-> #7478

@tfmorris
tfmorris merged commit 465179e into OpenRefine:master Oct 25, 2025
18 checks passed
@tfmorris
tfmorris deleted the 7504-database-driver-class branch October 25, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smierz smierz smierz approved these changes
@SoryRawyer SoryRawyer Awaiting requested review from SoryRawyer

Assignees

No one assigned

Labels

maintainability Making it easier to maintain OpenRefine SQL/database Integration with SQL databases in general Type: Bug Issues related to software defects or unexpected behavior, which require resolution.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Don't hide database driver class references in opaque strings

2 participants

@tfmorris @smierz