[smierz]

fixes #5794

Changes proposed in this pull request:

• change class name of mysql driver from "com.mysql.jdbc.Driver" to "com.mysql.cj.jdbc.Driver"
• the warning is triggered by this line in MySQLConnectionManager:
  

  OpenRefine/extensions/database/src/com/google/refine/extension/database/mysql/MySQLConnectionManager.java

  Line 133 in b3693e0

  Class.forName(type.getClassPath());

  
  To have a quick way to reproduce the warning and see that it disappears after the change I added the "test", but the commit "reproduce warning" can be dropped before merging.

Source

The name of the class that implements java.sql.Driver in MySQL Connector/J has changed from com.mysql.jdbc.Driver to com.mysql.cj.jdbc.Driver. The old class name has been deprecated.

Source: https://dev.mysql.com/doc/connectors/en/connector-j-upgrading-to-8.0.html

[Copilot]

Pull Request Overview

This PR updates the MySQL JDBC driver class name from the deprecated com.mysql.jdbc.Driver to the current com.mysql.cj.jdbc.Driver to resolve a deprecation warning and ensure compatibility with MySQL Connector/J 8.0+.

Key Changes:

• Updated MySQL driver class constant to use the modern JDBC driver
• Added a test to verify the driver class can be loaded

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
MySQLDatabaseService.java	Updated DB_DRIVER constant to use the current MySQL JDBC driver class
MySQLConnectionManagerTest.java	Added test to verify driver class loading works correctly

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[tfmorris]

Suggested change

	public static final String DB_DRIVER = "com.mysql.cj.jdbc.Driver";
	public static final String DB_DRIVER = com.mysql.cj.jdbc.Driver.class.getCanonicalName();

I dislike hiding class names in strings unless there's no choice. Is there any reason for us to not just use the class reference so that our tooling can help us track dependencies?

(I understand that this problem was not introduced by your PR)

[tfmorris]

I went ahead and updated the PR based on my suggestion and dropped the test.

I've created #7504 to address the driver class references in the rest of the database drivers.