Repository navigation
feat: improve v1beta1 component config override import logic - #5474
Merged
Merged
Conversation
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
β Deploy Preview for zarf-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Codecov Reportβ All modified and coverable lines are covered by tests.
... and 2 files with indirect coverage changes π New features to boost your workflow:
|
AustinAbro321
force-pushed
the
component-config-override-importability
branch
from
October 26, 2026 14:59
03f21e8 to
3043e31
Compare
AustinAbro321
marked this pull request as ready for review
October 26, 2026 16:07
Signed-off-by: Austin Abro <austinabro321@gmail.com>
AustinAbro321
commented
Oct 26, 2026
| "flavor", flavor, | ||
| ) | ||
|
|
||
| if !hasFlavoredComponentV1Beta1(pkg, flavor) { |
Member
Author
There was a problem hiding this comment.
Decided to remove this as I noticed there is a bug where this activates if the flavor is only used by component variants. We could track variants separately, but seems a bit complex for a warning log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There are some ways in which v1beta1 does not match the importability of v1alpha1. For instance, you cannot change namespace of a chart as you could before.
What you lose that you could change in v1alpha1 is the chart URL, but I think at that point it probably makes sense to have a different component.
Also components now go through validation before they're published. Technically not needed as some required items could be set through future imports, but I think it makes sense for published components to be valid to start and then be overwritten
Related Issue
Relates to #3433
Checklist before merging