Repository navigation
feat(dev): add --components flag to dev inspect values-files - #5413
Conversation
Signed-off-by: dalehenries <dale.henries@defenseunicorns.com>
✅ Deploy Preview for zarf-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Scope note: This PR applies Filtering before remote imports would require changes to the loader and decisions about imported values and validation. I treated that as a separate change. Please let me know if you expect |
Codecov Report❌ Patch coverage is
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
brandtkeller
left a comment
There was a problem hiding this comment.
I think that note on scope is a worthy consideration. A quick look and it does look like that would be a larger change but not misaligned or requiring any future breaking changes with what is added here.
Given that, I'd be in favor of these changes barring any other feedback from additional reviewers.
AustinAbro321
left a comment
There was a problem hiding this comment.
LGTM, nice job. Feel free to make another PR to update zarf dev inspect manifests with the same --components flag if you're interested
…v#5413) Signed-off-by: dalehenries <dale.henries@defenseunicorns.com>
Description
Change
Add
--componentstozarf dev inspect values-files, matching the component selection available when inspecting a built package.The flag selects which components’ charts are rendered and displayed. Zarf still resolves and validates the full source package, and values templates retain the full package context. An unknown selection returns a clear error.
Added command tests, a CLI E2E check, and the generated command reference.
Motivation
I use
zarf dev inspect values-filesto check Helm values before building a package. My package has two components that use the same upstream helm chart, so the unfiltered output gives both values documents the same chart label. Selecting a component makes it clear which values belong to which component.Related Issue
Fixes #5416
Validation
go test ./src/cmd -run '^TestDevInspectValuesFiles$' -count=1— passedgo test ./src/pkg/packager -run '^TestInspectDefinitionResources$' -count=1— passedgo test ./src/test/e2e/ -run 'TestUseCLI/zarf_dev_inspect_values-files' -count=1 -failfast— passedmake docs-and-schemaon Linux — passedmake lint-go— fails on 10SA1019deprecation findings in unchanged filesChecklist before merging