Repository navigation
Permissions Policy: test that the allow attribute ignores wildcard hosts - #63313
Open
marcoscaceres wants to merge 1 commit into
Open
marcoscaceres wants to merge 1 commit into
marcoscaceres wants to merge 1 commit into
Conversation
Collaborator
|
There are no reviewers for this pull request. Please reach out on the chat room to get help with this. Thank you! |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused tests correctly cover invalid wildcard entries and valid explicit-origin behavior.
Review effort: Balanced
Findings: None
What changed in this PR
Adds coverage ensuring iframe allow attributes ignore wildcard-host entries while retaining valid explicit origins.
Changes:
- Adds wildcard, mixed, and explicit-origin fullscreen policy tests.
- Adds a helper page reporting
document.fullscreenEnabled.
| File | Description |
|---|---|
permissions-policy/​resources/​report-fullscreen-enabled.html |
Reports fullscreen policy availability to the parent. |
permissions-policy/​permissions-policy-allow-attribute-wildcard-hosts.https.sub.html |
Tests wildcard-host handling in iframe allowlists. |
đź’ˇ Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests that the iframe allow attribute ignores allowlist entries whose host contains "*". Spec change: w3c/webappsec-permissions-policy#595.