Repository navigation
Ignore wildcard hosts in the iframe allow attribute - #595
Open
marcoscaceres wants to merge 1 commit into
Open
marcoscaceres wants to merge 1 commit into
marcoscaceres wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused algorithm change correctly implements the stated browser-compatible behavior without affecting header parsing.
Review effort: Balanced
Findings: None
What changed in this PR
Updates iframe allow parsing to ignore wildcard host entries while preserving wildcard support for HTTP headers.
Changes:
- Rejects parsed iframe allowlist origins whose domain contains
*. - Retains existing handling for valid, non-opaque origins.
| File | Description |
|---|---|
index.bs |
Excludes wildcard domains from iframe allow expressions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
|
I'm fine with this going in as-is since it described reality, but alternately should we allow this? @clelland |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chromium, Gecko and WebKit don't match wildcard hosts like
https://*.example.comin the iframe allow attribute: Chromium rejects them, and Gecko and WebKit never match them. This makes the attribute ignore such entries, while the Permissions-Policy header keeps the wildcard support added in #516.Tests: web-platform-tests/wpt#63313
Preview | Diff