Repository navigation
Remove ShadowRealm test coverage - #59794
Merged
Merged
Conversation
wpt-pr-bot
requested review from
MattiasBuelens,
Ms2ger,
asutherland,
domenic,
domfarolino,
eqrion,
foolip,
igrigorik,
jdm,
jgraham,
mikewest and
mkruisselbrink
May 11, 2026 16:38
domfarolino
approved these changes
May 11, 2026
domfarolino
left a comment
domfarolino
left a comment
Member
There was a problem hiding this comment.
Thanks, I'm supportive of this!
eqrion
approved these changes
May 11, 2026
eqrion
left a comment
eqrion
left a comment
Contributor
There was a problem hiding this comment.
LGTM for the WebAssembly tests.
Ms2ger
approved these changes
May 12, 2026
Ms2ger
left a comment
Ms2ger
left a comment
Contributor
There was a problem hiding this comment.
Sadly this seems like the way to go. LGTM modulo the one comment below.
This intentionally does not make infrastructure or documentation changes, but without implementer support all the ShadowRealm tests add significant noise. Once there is implementer support this can be reverted.
annevk
force-pushed
the
annevk/shadowrealm
branch
from
May 12, 2026 07:44
fa9f761 to
5673b76
Compare
wpt-pr-bot
requested review from
TimothyGu,
titzer,
wanderview,
youennf and
yuki3
May 12, 2026 07:45
Member
Author
|
Thanks for the reviews. I reverted the changes to |
This was referenced May 17, 2026
This was referenced Aug 29, 2026
cursor Bot
pushed a commit
to anonrig/node
that referenced
this pull request
Aug 29, 2026
The TC39 ShadowRealm proposal remains unimplemented by browsers, and WPT removed ShadowRealm test coverage. Remove the Node.js host integration, the --experimental-shadow-realm CLI flag, and related tests. Refs: web-platform-tests/wpt#59794 Refs: nodejs#42528 Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com> Co-authored-by: Yagiz Nizipli <anonrig@users.noreply.github.com>
cursor Bot
pushed a commit
to anonrig/node
that referenced
this pull request
Aug 29, 2026
The TC39 ShadowRealm proposal remains unimplemented by browsers, and WPT removed ShadowRealm test coverage. Remove the Node.js host integration, the --experimental-shadow-realm CLI flag, and related tests. Refs: web-platform-tests/wpt#59794 Refs: nodejs#42528 Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com> Co-authored-by: Yagiz Nizipli <anonrig@users.noreply.github.com>
anonrig
added a commit
to anonrig/node
that referenced
this pull request
Sep 22, 2026
The TC39 ShadowRealm proposal remains unimplemented by browsers, and WPT removed ShadowRealm test coverage. Remove the Node.js host integration, the --experimental-shadow-realm CLI flag, and related tests. Refs: web-platform-tests/wpt#59794 Refs: nodejs#42528 Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com> Co-authored-by: Yagiz Nizipli <anonrig@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This intentionally does not make infrastructure or documentation changes, but without implementer support all the ShadowRealm tests add significant noise. Once there is implementer support this can be reverted.