Skip to content

refactor(langauge-core): codegen based on Generator - #3778

Merged
johnsoncodehk merged 24 commits into
masterfrom
refactor-codegen
Dec 6, 2023
Merged

johnsoncodehk merged 24 commits into
masterfrom
refactor-codegen

Conversation

@johnsoncodehk

Copy link
Copy Markdown
Member

To reduce codegen function context, for past code:

function generateScript() {

	const codes = [];

	return codes;

	function generateSrc() {
		codes.push(...);
	}
	function generateHelperTypes() {
		codes.push(...);
	}
}

It should refactor to:

function generateScript() {

	yield* generateSrc();
	yield* generateHelperTypes();

	function generateSrc() {
		yield ...;
	}
	function generateHelperTypes() {
		yield ...;
	}
}

And codegen should be able to split into smaller files more easily in the future.

Base automatically changed from volar-1.12 to master December 6, 2023 13:54
@johnsoncodehk
johnsoncodehk merged commit f0d1af7 into master Dec 6, 2023
@johnsoncodehk
johnsoncodehk deleted the refactor-codegen branch December 6, 2023 14:03
so1ve pushed a commit to so1ve/vuejs-language-tools that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant