[Take Over mode] Not inserting * on enter in JSDoc #974

Activity

1. zardoy commented on Feb 21, 2022

   

   zardoy

   on Feb 21, 2022

   Last edited by zardoy

   ContributorAuthor

   More actions

   I'm just curios. How it compares to builtin TypeScript plugin?

   I can see that files are not being downloaded / patched from vscode repo. I also wonder why original TS plugin isn't being patched by using something like monkey patch.

   If the implementation is independent, is it possible to expect some extra features that we have been waiting for years, such as correct sorting of suggestions or disabling import suggestions from specific library?

   EDIT: Just got some thoughts from #471. However "hacking" into ext and ext reload after each update (that occurs once a month) wasn't so bad solution IMO.
2. johnsoncodehk commented on Mar 2, 2022

   

   johnsoncodehk

   on Mar 2, 2022

   Last edited by johnsoncodehk

   Member

   More actions

   Can you reproduce this problem in https://github.com/johnsoncodehk/volar-starter?

   If the implementation is independent, is it possible to expect some extra features that we have been waiting for years, such as correct sorting of suggestions or disabling import suggestions from specific library?

   We need to be consistent with VSCode, because their designed behavior is verified by more users, and changing it in volar might be counterproductive.

   EDIT: Just got some thoughts from #471. However "hacking" into ext and ext reload after each update (that occurs once a month) wasn't so bad solution IMO.

   Svelte is also looking a way to avoid it, I think we will not go back. 😅
   sveltejs/language-tools#1358
3. zardoy commented on Mar 2, 2022

   

   zardoy

   on Mar 2, 2022

   Last edited by zardoy

   ContributorAuthor

   More actions

   Can you reproduce this problem in johnsoncodehk/volar-starter?

   I think it'd more useful if I just attach a demo:

   

   As you can see pressing enter actually inserts asterisk. But takeover (when builtin TypeScript features ext disabled) mode doesn't do this.

   👍React with 👍1Reacted by Mario Valle
4. zardoy commented on Mar 6, 2022

   

   zardoy

   on Mar 6, 2022

   ContributorAuthor

   More actions

   Can't repro anymore, everything works perfectly. Have no idea why it didn't work before.
5. zardoy

   closed this as completedon Mar 6, 2022
6. johnsoncodehk commented on Mar 7, 2022

   

   johnsoncodehk

   on Mar 7, 2022

   Member

   More actions

   I think it was changed in microsoft/vscode#125748.

   👍React with 👍1Reacted by Vitaly
7. johnsoncodehk

   added

   upstream

   on Mar 7, 2022