Skip to content

refactor: Remove clap from turborepo-types - #14111

Merged
anthonyshew merged 1 commit into
mainfrom
anthonyshew/turbo-5897-remove-clap-from-turborepo-types
Sep 20, 2026
Merged

anthonyshew merged 1 commit into
mainfrom
anthonyshew/turbo-5897-remove-clap-from-turborepo-types

Conversation

@anthonyshew

Copy link
Copy Markdown
Contributor

Summary

  • Remove clap::ValueEnum derives and the direct clap dependency from turborepo-types.
  • Keep CLI parsing in the existing usage-rs-compatible argument wrappers.
  • Replace turborepo-config's clap-based environment parsing with a local, case-insensitive LogOrder mapping and remove its now-unused clap and itertools dependencies.

Dependency boundary

 turborepo-types
-โ””โ”€โ”€ clap::ValueEnum
+โ””โ”€โ”€ parser-agnostic shared enums

 turborepo-config
-โ””โ”€โ”€ clap::ValueEnum (environment parsing)
+โ””โ”€โ”€ local string-to-LogOrder mapping

Consumer dependency trees may still contain clap through the unrelated turbo-trace -> turborepo-boundaries path; this removes the paths originating in turborepo-types and turborepo-config.

Fixes TURBO-5897

@anthonyshew
anthonyshew requested review from a team and tknickman September 20, 2026 02:22
@vercel

vercel Bot commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
examples-basic-web Ready Ready Preview, v0 Sep 20, 2026 2:25am UTC
examples-designsystem-docs Ready Ready Preview, v0 Sep 20, 2026 2:25am UTC
examples-gatsby-web Ready Ready Preview, v0 Sep 20, 2026 2:25am UTC
examples-kitchensink-blog Ready Ready Preview, v0 Sep 20, 2026 2:25am UTC
examples-nonmonorepo Ready Ready Preview, v0 Sep 20, 2026 2:25am UTC
examples-svelte-web Ready Ready Preview, v0 Sep 20, 2026 2:25am UTC
examples-tailwind-web Ready Ready Preview, v0 Sep 20, 2026 2:25am UTC
examples-vite-web Ready Ready Preview, v0 Sep 20, 2026 2:25am UTC
turbo-site Ready Ready Preview, v0 Sep 20, 2026 2:25am UTC
turborepo-factory Error Error v0 Sep 20, 2026 2:25am UTC

@anthonyshew
anthonyshew merged commit 1fc6e60 into main Sep 20, 2026
67 of 70 checks passed
@anthonyshew
anthonyshew deleted the anthonyshew/turbo-5897-remove-clap-from-turborepo-types branch September 20, 2026 02:40
github-actions Bot added a commit that referenced this pull request Sep 20, 2026
## Release v2.11.3-canary.1

> [!CAUTION]
> Versioned docs aliasing FAILED. [View
logs](https://github.com/vercel/turborepo/actions/runs/35513462277)

### Changes

- chore: Release Turborepo 2.10.14-canary.5 (#14098) (`613b3ba`)
- test: Fix Windows cache restore test (#14099) (`2c49c23`)
- chore: Update with-prisma example (#14101) (`f21d73f`)
- chore: Release Turborepo 2.11.0 (#14102) (`471f085`)
- docs: Add Turborepo 2.11 release post (#13652) (`9dec1d2`)
- fix: Allow esbuild builds for pnpm generators (#14103) (`eb2faaf`)
- chore: Release Turborepo 2.11.1 (#14104) (`417d6aa`)
- fix: Restore repeatable CLI flags (#14106) (`9d8df19`)
- chore: Release Turborepo 2.11.2 (#14107) (`bcc853c`)
- refactor: Remove experimental Cargo compile cache (#14110) (`c14db49`)
- refactor: Remove clap from turborepo-types (#14111) (`1fc6e60`)
- chore: Use canary turbo for Vercel builds (#14112) (`d3b74e7`)
- refactor: Extract turborepo-tracing crate (#14113) (`edc9f82`)
- refactor: Remove Run boundaries extension (#14114) (`18c7be1`)
- refactor: Relocate child spawning to turborepo-process (#14115)
(`5960801`)
- docs: Drop stale support-policy entry from getting-started nav
(#14116) (`4735da1`)
- refactor: Move CLI configuration overrides into CLI (#14119)
(`c61a4cb`)
- fix: Avoid microfrontend polyrepo warnings (#14118) (`530f2eb`)
- refactor: Add run and execution selector DTOs (#14120) (`b730cdb`)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
pull Bot pushed a commit to Dustin4444/turborepo that referenced this pull request Sep 22, 2026
## Release v2.11.3

> [!CAUTION]
> Versioned docs aliasing FAILED. [View
logs](https://github.com/vercel/turborepo/actions/runs/35779237464)

### Changes

- chore: Release Turborepo 2.11.2 (vercel#14107) (`bcc853c`)
- refactor: Remove experimental Cargo compile cache (vercel#14110) (`c14db49`)
- refactor: Remove clap from turborepo-types (vercel#14111) (`1fc6e60`)
- chore: Use canary turbo for Vercel builds (vercel#14112) (`d3b74e7`)
- refactor: Extract turborepo-tracing crate (vercel#14113) (`edc9f82`)
- refactor: Remove Run boundaries extension (vercel#14114) (`18c7be1`)
- refactor: Relocate child spawning to turborepo-process (vercel#14115)
(`5960801`)
- docs: Drop stale support-policy entry from getting-started nav
(vercel#14116) (`4735da1`)
- refactor: Move CLI configuration overrides into CLI (vercel#14119)
(`c61a4cb`)
- fix: Avoid microfrontend polyrepo warnings (vercel#14118) (`530f2eb`)
- refactor: Add run and execution selector DTOs (vercel#14120) (`b730cdb`)
- chore: Release Turborepo 2.11.3-canary.1 (vercel#14121) (`19afae0`)
- test: Reuse Go cache in invalidation test (vercel#14122) (`ba7f8a1`)
- chore: Release Turborepo 2.11.3-canary.2 (vercel#14124) (`cfe2f20`)
- test: Avoid overlapping concurrent cache restores (vercel#14125) (`da00de7`)
- refactor: Rewire Opts to consume selectors (vercel#14126) (`ae55ecc`)
- refactor: Extract task filtering into dedicated crate (vercel#14127)
(`6564345`)
- refactor: Extract task access into dedicated crate (vercel#14128)
(`c12b1f1`)
- refactor: Extract MicrofrontendsConfigs (vercel#14133) (`b5f9880`)
- chore: Update with-rollup example (vercel#14123) (`748aff9`)
- refactor: Move unified turbo.json loader (vercel#14134) (`c031520`)
- refactor: Extract package watcher crate (vercel#14135) (`88c2f90`)
- refactor: Extract prune input DTO (vercel#14136) (`307e2d2`)
- fix: Ignore gitignored files in boundaries (vercel#14137) (`773b3d9`)
- fix: Stabilize boundaries tag order in prune (vercel#14138) (`b64369e`)
- fix: Normalize affected task input globs (vercel#14140) (`00ee364`)
- chore: Release Turborepo 2.11.3-canary.3 (vercel#14141) (`a3b6df8`)
- refactor: Extract prune orchestration (vercel#14142) (`357e766`)
- ci: Update Node.js test matrices (vercel#14139) (`b437bf1`)
- refactor: Add Turborepo run context crate (vercel#14143) (`b8a9a8c`)
- refactor: Add repository run context (vercel#14144) (`1876b23`)
- refactor: Use RepoContext in task graph visitor (vercel#14145) (`a29a419`)
- refactor: Extract repository discovery from run builder (vercel#14146)
(`82031c9`)
- refactor: Extract run execution context construction (vercel#14147)
(`c3efb59`)
- refactor: Extract run services construction (vercel#14148) (`0750df6`)
- refactor: Promote task graph to dedicated crate (vercel#14150) (`d7e061b`)
- refactor: Extract run options into dedicated crate (vercel#14152)
(`fb0a9ec`)
- docs: Remove duplicated word in the 1.9 blog post (vercel#14129) (`3bf6ef8`)
- refactor: Promote run and watch to dedicated crates (vercel#14153)
(`87bccbe`)
- refactor: Extract run command orchestration (vercel#14154) (`1dead3c`)
- refactor: Rename `turborepo-lib` to `turborepo-cli` (vercel#14155)
(`f81062f`)
- refactor: Slim query API interface (vercel#14157) (`5614369`)
- fix(affected): Treat root internal dependency changes as global
(vercel#14156) (`69b7c6b`)
- refactor: Move engine validation into turborepo-engine (vercel#14158)
(`4f23af2`)
- test: Harden weak tests and shared assertion helpers (vercel#14159)
(`ad8379b`)
- chore: Update with-rsbuild-module-federation example (vercel#14160)
(`c079ed3`)
- perf: Reuse parsed lockfile during lazy graph loading (vercel#14161)
(`dd1d31a`)
- chore: Release Turborepo 2.11.3-canary.4 (vercel#14162) (`fb2fb0c`)
- fix: Stop with tasks when parent exits (vercel#14163) (`fde6637`)
- fix: Respect negated global dependencies in affected detection
(vercel#14164) (`83f6d32`)

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

This branch had an error being deployed

1 failed deployment
Preview โ€“ turborepo-factory โ€” 09f227c9 Deployed Sep 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant