Repository navigation
build: update lock file - #3963
Conversation
| "jsonschema>=3.0", | ||
| "packaging", | ||
| "narwhals>=1.27.1" | ||
| "narwhals>=1.27.1,<2.2" |
There was a problem hiding this comment.
hi @mattijn - is this just for internal typing purposes?
if so, i'd really advise against setting an upper bound on a required dependency, this risks causing further issues
you may have seen this already, but i think it's argued quite well here: https://iscinumpy.dev/post/bound-version-constraints/
There was a problem hiding this comment.
Thanks for commenting. We have no intention of releasing an altair version with an upper bound on narwhals, but since the test suite currently fails with higher versions, I’ve temporarily added this mitigation measure while waiting for it to be resolved upstream. If you have a better suggestion, I’m completely open to it.
There was a problem hiding this comment.
makes sense, thanks - will treat addressing this with priority then 👍
This PR updates the lock file
To make sure all tests pass I have to: