Skip to content

build: update lock file - #3963

Merged
mattijn merged 3 commits into
mainfrom
update-lock-file;-narwhals-pinned-below-2.2
Feb 21, 2026
Merged

mattijn merged 3 commits into
mainfrom
update-lock-file;-narwhals-pinned-below-2.2

Conversation

@mattijn

@mattijn mattijn commented Feb 21, 2026

Copy link
Copy Markdown
Contributor

This PR updates the lock file

To make sure all tests pass I have to:

@mattijn
mattijn enabled auto-merge (squash) February 21, 2026 22:19
@mattijn
mattijn merged commit 903e68e into main Feb 21, 2026
25 checks passed
Comment thread pyproject.toml
"jsonschema>=3.0",
"packaging",
"narwhals>=1.27.1"
"narwhals>=1.27.1,<2.2"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @mattijn - is this just for internal typing purposes?

if so, i'd really advise against setting an upper bound on a required dependency, this risks causing further issues

you may have seen this already, but i think it's argued quite well here: https://iscinumpy.dev/post/bound-version-constraints/

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for commenting. We have no intention of releasing an altair version with an upper bound on narwhals, but since the test suite currently fails with higher versions, I’ve temporarily added this mitigation measure while waiting for it to be resolved upstream. If you have a better suggestion, I’m completely open to it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, thanks - will treat addressing this with priority then 👍

@joelostblom
joelostblom deleted the update-lock-file;-narwhals-pinned-below-2.2 branch June 5, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants