Skip to content

fix(typing): overload in eval_block incorrectly showed True as the default for strict - #3855

Merged
dangotbanned merged 1 commit into
vega:mainfrom
MarcoGorelli:fix-overload-default-eval-block
Jul 15, 2025
Merged

dangotbanned merged 1 commit into
vega:mainfrom
MarcoGorelli:fix-overload-default-eval-block

Conversation

@MarcoGorelli

Copy link
Copy Markdown
Contributor

Thanks for contributing to Altair! 🎉

Please follow these guidelines:

1. PR Description

  • Briefly describe the changes and their purpose. For help, check this guide.

2. Tests & Docs

  • Include unit tests and update documentation for new features.

3. Commit Message

  • Use semantic commit messages, e.g., "feat: Add embed_options to charts".
  • Add ! for breaking changes (e.g., "fix!: Raise error when embed_options is None").

4. PR Title Types

  • feat: New feature
  • fix: Bug fix
  • docs: Documentation changes
  • style: Code style changes (no functionality change)
  • refactor: Code restructuring
  • perf: Performance improvements
  • test: Add or fix tests
  • build: Changes to build system or dependencies
  • ci: CI configuration changes
  • chore: Miscellaneous tasks
  • revert: Reverts a commit

@MarcoGorelli
MarcoGorelli marked this pull request as ready for review July 15, 2025 09:27

@dangotbanned dangotbanned left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah well spotted @MarcoGorelli thank you!

There's a good chance there are other like this in altair from when I didn't understand @overloads as well

@dangotbanned dangotbanned added the typing Related to static typing/type hints label Jul 15, 2025
@dangotbanned
dangotbanned merged commit 3d05d6b into vega:main Jul 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance typing Related to static typing/type hints

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants