Repository navigation
fix(typing): overload in eval_block incorrectly showed True as the default for strict - #3855
Merged
dangotbanned merged 1 commit intoJul 15, 2025
Conversation
…e default for `strict`
MarcoGorelli
marked this pull request as ready for review
July 15, 2025 09:27
dangotbanned
approved these changes
Jul 15, 2025
dangotbanned
left a comment
Member
There was a problem hiding this comment.
Ah well spotted @MarcoGorelli thank you!
There's a good chance there are other like this in altair from when I didn't understand @overloads as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Altair! 🎉
Please follow these guidelines:
1. PR Description
2. Tests & Docs
3. Commit Message
"feat: Add embed_options to charts".!for breaking changes (e.g.,"fix!: Raise error when embed_options is None").4. PR Title Types