Repository navigation
chore(typing): Follow-up fix _from_array_like - #3812
Merged
Merged
Conversation
Have a better understanding *now* of what the issue is in (https://github.com/narwhals-dev/narwhals/actions/runs/13577097131/job/37955718895). - This patch is *functionally* the same - but removes the need for ignoring a (typing) warning following (narwhals-dev/narwhals@62f8a1f). - Should also mean we don't need to bump our `narwhals` minimum [again](#3807 (comment)). - **Bonus**: reduced overhead for `<3.11` (python/cpython#84403) ## Related - narwhals-dev/narwhals#2110 - #3811 - narwhals-dev/narwhals#2110 (comment) - narwhals-dev/narwhals#2110 (comment) - narwhals-dev/narwhals#2111
dangotbanned
commented
Feb 28, 2025
dangotbanned
marked this pull request as ready for review
February 28, 2025 12:17
dangotbanned
changed the title
_from_array_like_from_array_like
Member
Author
|
Wow 🤦♂️ #3812 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have a better understanding now of what the issue is in (https://github.com/narwhals-dev/narwhals/actions/runs/13577097131/job/37955718895).
narwhalsminimum again.<3.11("Zero cost" exception handling python/cpython#84403)Related
Seriestov1narwhals-dev/narwhals#2110nw.from_native(..., strict=True)#3811Seriestov1narwhals-dev/narwhals#2110 (comment)Seriestov1narwhals-dev/narwhals#2110 (comment)NativeSeriesProtocol narwhals-dev/narwhals#2111Update
Fixed it 🙂 (narwhals-dev/narwhals#2114 (comment))