Repository navigation
Upgrade to Vega-Lite 5.17.0 - #3367
Merged
Merged
Conversation
binste
marked this pull request as draft
March 16, 2024 14:03
binste
marked this pull request as ready for review
March 16, 2024 14:59
joelostblom
approved these changes
Mar 16, 2024
joelostblom
left a comment
joelostblom
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks @binste ! Maybe let's have one more approval since it is for the release?
jonmmease
approved these changes
Mar 16, 2024
jonmmease
left a comment
jonmmease
left a comment
Contributor
There was a problem hiding this comment.
lgtm, I skimmed through all of the generated code and it looks reasonable. And given that the tests I'm happy for this to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.