Skip to content

fix: Preference settings not have time zone option - #7871

Merged
jinmao88 merged 1 commit into
vbenjs:mainfrom
Linlccc:fix/not-have-timezone-setting
May 3, 2026
Merged

jinmao88 merged 1 commit into
vbenjs:mainfrom
Linlccc:fix/not-have-timezone-setting

Conversation

@Linlccc

@Linlccc Linlccc commented Apr 30, 2026 •

Copy link
Copy Markdown
Contributor

Description

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
  • Run the tests with pnpm test.
  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

  • New Features
    • Added a new timezone widget preference toggle in the preferences panel, allowing users to enable or disable the timezone widget display with full localization support.

@changeset-bot

changeset-bot Bot commented Apr 30, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 7fdb613

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Apr 30, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. πŸŽ‰

ℹ️ Recent review info
βš™οΈ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 49fdb024-646d-4438-a0dc-d91ee0610874

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between 99c38c9 and 7fdb613.

πŸ“’ Files selected for processing (4)
  • packages/effects/layouts/src/widgets/preferences/blocks/layout/widget.vue
  • packages/effects/layouts/src/widgets/preferences/preferences-drawer.vue
  • packages/locales/src/langs/en-US/preferences.json
  • packages/locales/src/langs/zh-CN/preferences.json

πŸ“ Walkthrough

Walkthrough

Adds a new widget timezone preference feature by introducing a boolean model in the preferences UI components and extending localization strings in English and Chinese to support the new timezone toggle setting.

Changes

Cohort / File(s) Summary
Widget Preferences Components
packages/effects/layouts/src/widgets/preferences/blocks/layout/widget.vue, packages/effects/layouts/src/widgets/preferences/preferences-drawer.vue
Added new widgetTimezone boolean model and wired it into template bindings to enable timezone preference toggle display and interaction.
Localization Strings
packages/locales/src/langs/en-US/preferences.json, packages/locales/src/langs/zh-CN/preferences.json
Added widget.timezone translation keys with English label "Enable Timezone" and Chinese equivalent "ε―η”¨ζ—ΆεŒΊ".

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • anncwb
  • vince292007
  • mynetfan
  • jinmao88

Poem

🐰 Hop, hop! A timezone toggle springs to life,
With models bound and translations rife,
In English bright and Chinese song,
Widget preferences grow ever strong!
β€”The Coding Rabbit 🌍✨

πŸš₯ Pre-merge checks | βœ… 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete; the main Description section is empty, providing no details about the bug or its fix. Add a detailed description explaining what the bug was, why it occurred, and how the fix addresses it.
βœ… Passed checks (4 passed)
Check name Status Explanation
Title check βœ… Passed The title clearly identifies the bug being fixed: adding a missing timezone option to preference settings.
Docstring Coverage βœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check βœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check βœ… Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
πŸ§ͺ Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@jinmao88
jinmao88 merged commit b5dacd9 into vbenjs:main May 3, 2026
2 of 5 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants