Skip to content

fix: vxe i18n - #7675

Merged
jinmao88 merged 7 commits into
vbenjs:mainfrom
xingyu4j:main
Mar 16, 2026
Merged

jinmao88 merged 7 commits into
vbenjs:mainfrom
xingyu4j:main

Conversation

@xingyu4j

@xingyu4j xingyu4j commented Mar 16, 2026 •

Copy link
Copy Markdown
Contributor

Description

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
  • Run the tests with pnpm test.
  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

  • Chores
    • Updated dependencies including vxe-table, vxe-pc-ui, and development tooling to latest patch and minor versions for improved stability and compatibility.

@changeset-bot

changeset-bot Bot commented Mar 16, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 66de2a0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Mar 16, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4c5da726-7db4-48c1-8e5d-fca31b1bdb58

📥 Commits

Reviewing files that changed from the base of the PR and between 37d72c1 and 66de2a0.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • packages/effects/plugins/src/vxe-table/init.ts
  • pnpm-workspace.yaml

📝 Walkthrough

Walkthrough

This pull request adds a locale module normalization helper function in the VxeTable plugin initialization and updates dependency versions in the workspace configuration. The helper ensures consistent locale module shapes by unwrapping default exports before passing them to VxeUI's i18n configuration.

Changes

Cohort / File(s) Summary
VxeTable Locale Normalization
packages/effects/plugins/src/vxe-table/init.ts
Introduces an internal helper function to normalize locale modules by unwrapping default exports and applies it to zh-CN and en-US locale mappings in the VxeUI setup flow.
Dependency Version Updates
pnpm-workspace.yaml
Updates minor and patch versions for dev dependencies: ast-grep-napi, commitlint packages, oxlint-tsgolint, and vxe UI libraries (vxe-pc-ui, vxe-table).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

bug

Suggested reviewers

  • anncwb
  • vince292007
  • mynetfan
  • jinmao88

Poem

🐰 A helper hops in to tidy the locales,
Unwrapping defaults like unpacking tales,
While dependencies dance to a newer beat,
vxe-table bounds and oxlint's feat,
Our workspace grows with precision so neat! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is empty and consists only of the template structure with no content filled in, including no explanation of the bug being fixed or the changes made. Fill in the Description section explaining what i18n issue was fixed and why. Check the Bug fix checkbox and describe the fix in detail.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: vxe i18n' is directly related to the main change: fixing VXE table i18n by normalizing locale modules in the vxe-table initialization code.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jinmao88
jinmao88 merged commit 186914b into vbenjs:main Mar 16, 2026
14 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants