Skip to content

fix: oxlint config - #7661

Merged
jinmao88 merged 4 commits into
vbenjs:mainfrom
xingyu4j:main
Mar 15, 2026
Merged

jinmao88 merged 4 commits into
vbenjs:mainfrom
xingyu4j:main

Conversation

@xingyu4j

@xingyu4j xingyu4j commented Mar 15, 2026 •

Copy link
Copy Markdown
Contributor

Description

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
  • Run the tests with pnpm test.
  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

Release Notes

  • Dependencies

    • Updated supported Node.js versions: now supports 20.19.0+, 22.13.0+, and 24.0.0+
    • Bumped antdv-next and stylelint-order packages
  • Chores

    • Refactored oxlint configuration structure
    • Cleaned up linting directives and comment formatting across multiple files

@changeset-bot

changeset-bot Bot commented Mar 15, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ab3e6bb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Mar 15, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 8af9e031-b46f-4481-adbe-93133abbf56f

📥 Commits

Reviewing files that changed from the base of the PR and between a8ae891 and ab3e6bb.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (16)
  • docs/src/_env/adapter/form.ts
  • docs/src/demos/vben-vxe-table/form/index.vue
  • eslint.config.mjs
  • internal/vite-config/src/plugins/extra-app-config.ts
  • internal/vite-config/src/plugins/importmap.ts
  • oxlint.config.ts
  • package.json
  • packages/@core/ui-kit/layout-ui/src/components/layout-content.vue
  • packages/@core/ui-kit/shadcn-ui/src/components/full-screen/full-screen.vue
  • packages/@core/ui-kit/tabs-ui/src/components/tabs-chrome/tabs.vue
  • packages/effects/common-ui/src/components/captcha/slider-translate-captcha/index.vue
  • packages/effects/common-ui/src/components/json-viewer/index.vue
  • packages/effects/layouts/src/widgets/global-search/global-search.vue
  • packages/effects/layouts/src/widgets/theme-toggle/theme-button.vue
  • pnpm-workspace.yaml
  • scripts/vsh/src/publint/index.ts
💤 Files with no reviewable changes (7)
  • scripts/vsh/src/publint/index.ts
  • packages/effects/layouts/src/widgets/global-search/global-search.vue
  • internal/vite-config/src/plugins/extra-app-config.ts
  • packages/effects/common-ui/src/components/captcha/slider-translate-captcha/index.vue
  • eslint.config.mjs
  • internal/vite-config/src/plugins/importmap.ts
  • docs/src/_env/adapter/form.ts

📝 Walkthrough

Walkthrough

This PR removes linter disable comments and reformats comment directives throughout the codebase. It also restructures the oxlint configuration import pattern, updates Node version constraints in package.json to support Node 22 and 24, and bumps minor dependency versions in the workspace catalog.

Changes

Cohort / File(s) Summary
Lint Comment Removals
docs/src/_env/adapter/form.ts, internal/vite-config/src/plugins/extra-app-config.ts, internal/vite-config/src/plugins/importmap.ts, packages/effects/common-ui/src/components/captcha/slider-translate-captcha/index.vue, packages/effects/layouts/src/widgets/global-search/global-search.vue, scripts/vsh/src/publint/index.ts
Removed various oxlint and TypeScript linter disable comments without altering runtime behavior.
Comment Formatting Updates
docs/src/demos/vben-vxe-table/form/index.vue, packages/@core/ui-kit/layout-ui/src/components/layout-content.vue, packages/@core/ui-kit/shadcn-ui/src/components/full-screen/full-screen.vue, packages/@core/ui-kit/tabs-ui/src/components/tabs-chrome/tabs.vue, packages/effects/common-ui/src/components/json-viewer/index.vue, packages/effects/layouts/src/widgets/theme-button.vue
Reformatted ts-expect-error and @ts-ignore comment directives by adjusting punctuation (adding dashes) with no functional impact.
ESLint Configuration
eslint.config.mjs
Removed the `// @ts-check` directive; functional configuration remains unchanged.
Oxlint Configuration Restructure
oxlint.config.ts
Changed import pattern from importing defineConfig from @vben/oxlint-config to importing oxlintConfig from the same module and defineConfig from oxlint, then passing oxlintConfig to defineConfig().
Package Configuration Updates
package.json, pnpm-workspace.yaml
Updated Node engines from >=20.19.0 to `^20.19.0

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested labels

chore

Suggested reviewers

  • anncwb
  • vince292007
  • mynetfan
  • jinmao88

Poem

🐰 Lint comments fade away so neat,
Config patterns now compete,
Node versions dance with glee,
Dependencies updated with care we see!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is completely empty—it only contains the unchecked template with no actual details about the changes, rationale, or affected files. Add a detailed description explaining the oxlint config changes, Node engine updates, and the rationale for removing lint-disable comments throughout the codebase.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix: oxlint config' accurately reflects the main change in the PR, which involves updating the oxlint configuration structure in oxlint.config.ts and removing lint-disable comments across multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xingyu4j xingyu4j changed the title fix: Update Node engines and fix oxlint config fix: oxlint config Mar 15, 2026
@wu-clan

wu-clan commented Mar 15, 2026

Copy link
Copy Markdown
Contributor

Can it be merged directly?

@xingyu4j

Copy link
Copy Markdown
Contributor Author

可以直接合并吗?

可以的,主要是去掉了一些没用的检测,然后修复了oxlint在编辑器里不能正常启动service的问题

@jinmao88
jinmao88 merged commit 37d72c1 into vbenjs:main Mar 15, 2026
14 of 15 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 15, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants