Skip to content

fix: fix password input icon visual bug in certain browser - #7521

Merged
jinmao88 merged 1 commit into
vbenjs:mainfrom
tikitoki:main
Feb 6, 2026
Merged

jinmao88 merged 1 commit into
vbenjs:mainfrom
tikitoki:main

Conversation

@tikitoki

@tikitoki tikitoki commented Feb 6, 2026 •

Copy link
Copy Markdown
Contributor

Description

1.Use Edge browser to open https://naive.vben.pro/#/auth/login
2.clear password then input one character
3.results to this
企业微信截图_17703465142050

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

  • [✅️ ] Run the tests with pnpm test.
  • [ ✅️] Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
  • [✅️ ] My code follows the style guidelines of this project
  • [ ✅️] My changes generate no new warnings

Summary by CodeRabbit

  • Style
    • Refined input field styling to provide a cleaner, more consistent visual experience by streamlining the display of browser interface elements across different platforms.

@changeset-bot

changeset-bot Bot commented Feb 6, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ace770c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Feb 6, 2026 •

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

CSS rules were added to the Input component to hide native browser UI elements including Microsoft password reveal controls, WebKit autofill buttons, and spin button controls for a cleaner input field appearance.

Changes

Cohort / File(s) Summary
Input Component Styling
packages/@core/ui-kit/shadcn-ui/src/ui/input/Input.vue
Added CSS rules to hide browser-native UI elements (password reveal, autofill buttons, spin buttons) within input fields.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested labels

bug

Suggested reviewers

  • anncwb
  • vince292007
  • mynetfan

Poem

🐰 A hop and a bound through the input field,
Where native controls have now been sealed,
No more spin buttons or cryptic reveals,
Just clean, pristine inputs with maximum feels! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description includes reproduction steps, a screenshot of the issue, and marks the type of change as a bug fix. However, it is incomplete: missing documentation updates confirmation, self-review statement, code comments, test additions, and several other checklist items are not marked.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check ✅ Passed The title accurately describes the main change: fixing a visual bug in the password input icon/visibility toggle in certain browsers (specifically Edge).

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tikitoki tikitoki changed the title fix:fix password input icon visual bug in certain browser fix: fix password input icon visual bug in certain browser Feb 6, 2026
@jinmao88
jinmao88 merged commit e9eab29 into vbenjs:main Feb 6, 2026
4 of 6 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants