Skip to content

fix: #7140 - #7153

Merged
jinmao88 merged 6 commits into
vbenjs:mainfrom
xingyu4j:main
Jan 28, 2026
Merged

jinmao88 merged 6 commits into
vbenjs:mainfrom
xingyu4j:main

Conversation

@xingyu4j

@xingyu4j xingyu4j commented Jan 28, 2026 •

Copy link
Copy Markdown
Contributor

Description

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
  • Run the tests with pnpm test.
  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

  • Bug Fixes

    • Reset modal state on close to ensure reliable re-creation.
  • Chores

    • Updated package manager to pnpm@10.28.2 and bumped multiple package versions.
    • Upgraded GitHub Actions and Node targets across workflows.
    • Enabled ESLint validation for YAML.
    • Added internal DOM refs across UI components in preparation for future interactions (no visible behavior changes).

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot

changeset-bot Bot commented Jan 28, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3a95af0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jan 28, 2026 •

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Adds template DOM refs (with TypeScript suppressions) across multiple UI components, replaces aliased ref bindings with direct refs, resets a modal injected consumed flag before re-creation when destroyOnClose is true, and updates ESLint, pnpm, dependency pins, Node version, and GitHub Actions checkout/setup-node versions.

Changes

Cohort / File(s) Summary
DOM reference additions
packages/@core/ui-kit/form-ui/src/form-render/form.vue, packages/@core/ui-kit/layout-ui/src/components/layout-sidebar.vue, packages/@core/ui-kit/popup-ui/src/drawer/drawer.vue, packages/@core/ui-kit/popup-ui/src/modal/modal.vue, packages/@core/ui-kit/tabs-ui/src/components/tabs-chrome/tabs.vue
Added template refs (e.g., wrapperRef, asideRef, footerRef, contentRef, tabRef) and // @ts-expect-error unused annotations; refs are attached in templates but not otherwise used.
Ref binding refactor
packages/@core/ui-kit/layout-ui/src/components/layout-content.vue, packages/@core/ui-kit/tabs-ui/src/tabs-view.vue
Replaced aliased destructures (_contentElement, _scrollbarRef) with direct destructured refs (contentElement, scrollbarRef) and updated template bindings accordingly.
Modal lifecycle change
packages/@core/ui-kit/popup-ui/src/modal/use-modal.ts, packages/@core/ui-kit/popup-ui/src/modal/modal.vue
On close with destroyOnClose, reset injected consumed flag to false before calling reCreateModal; modal.vue also exposes new wrapperRef and footerRef template refs.
Config / deps / workflows
.vscode/settings.json, package.json, pnpm-workspace.yaml, .node-version, .github/actions/setup-node/action.yml, .github/workflows/...`
Added "yaml" to eslint.validate; bumped packageManager from pnpm@10.28.1→pnpm@10.28.2; updated multiple dependency versions in workspace; bumped Node pin and upgraded GitHub Actions actions/checkout and actions/setup-node usages to newer versions.

Sequence Diagram(s)

(omitted — changes are small internal refs and config/workflow updates that do not introduce a new multi-component control flow requiring visualization)

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested labels

bug

Suggested reviewers

  • anncwb
  • vince292007
  • mynetfan
  • jinmao88

"I'm a rabbit with a dev-time hop,
Refs tucked in, then one small stop,
Modal reset, versions climb,
Lint now checks the YAML line,
Tiny hops toward smoother dev-time." 🐇✨

🚥 Pre-merge checks | ❌ 3
❌ Failed checks (2 warnings, 1 inconclusive)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description contains only the template structure with no actual content filled in—no description of changes, issue details, or explanation of what was fixed. Fill in the Description section with details about issue #7140, explain the changes made, and check appropriate boxes in the Type of change section.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'fix: #7140' references an issue but lacks specificity about what problem is being fixed or what changes are made. Expand the title to briefly describe the actual fix (e.g., 'fix: add template refs for drawer/modal/form components and update dependencies').

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jinmao88
jinmao88 merged commit 7680b33 into vbenjs:main Jan 28, 2026
14 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants