Skip to content

fix: εˆ‡ζ’ζ—ΆεŒΊεŽοΌŒι‘΅ι’δΈεˆ·ζ–° - #7085

Merged
jinmao88 merged 2 commits into
vbenjs:mainfrom
yuhengshen:vben-main
Jan 10, 2026
Merged

jinmao88 merged 2 commits into
vbenjs:mainfrom
yuhengshen:vben-main

Conversation

@yuhengshen

@yuhengshen yuhengshen commented Jan 8, 2026 •

Copy link
Copy Markdown
Contributor

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs:dev command.
  • Run the tests with pnpm test.
  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Summary by CodeRabbit

  • Bug Fixes
    • Layout now fully refreshes when timezone or language/locale settings change, ensuring all time-sensitive content updates immediately.
    • Tab view cache is cleared on those changes so open tabs reflect updated content and state without manual reload.

✏️ Tip: You can customize this high-level summary in your review settings.

@changeset-bot

changeset-bot Bot commented Jan 8, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 07497d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Jan 8, 2026 •

Copy link
Copy Markdown
Contributor
πŸ“ Walkthrough

Walkthrough

layout.vue now imports and watches the timezone store and tabbar store; it adds a refreshAll() that clears cached tabs and triggers a UI refresh, and replaces locale-based refresh calls with refreshAll to react to timezone or locale changes.

Changes

Cohort / File(s) Summary
Layout β€” timezone & tabbar integration
packages/effects/layouts/src/basic/layout.vue
Added useTimezoneStore and useTabbarStore imports and instantiations; introduced refreshAll() that clears tabbarStore.cachedTabs and calls existing refresh(); replaced locale watcher to call refreshAll; added watcher on timezoneStore.timezone to call refreshAll.

Sequence Diagram(s)

(omitted β€” change is small and does not introduce a multi-step cross-system flow that warrants a diagram)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • #6864: Changes timezone store API/behavior that this PR watches to trigger UI refreshes.
  • #4652: Modifies tabbar store behavior related to tab titles and pin/unpin, related to clearing cachedTabs.

Suggested labels

bug

Suggested reviewers

  • anncwb
  • vince292007
  • mynetfan
  • jinmao88

Poem

πŸ‡ I nibble code beneath the moonlit sky,

When timezones hop, the layout springs to vie.
Cached tabs cleared, the UI finds its tune,
A tiny hop β€” refresh beneath the moon.

πŸš₯ Pre-merge checks | βœ… 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is incomplete; it lacks the required Description section explaining the bug/issue being fixed and the implementation approach. Only the Type of change and Checklist sections are present. Add a Description section that explains the bug (page not refreshing after timezone switch), the root cause, and how the fix resolves it. This section is required per the template.
βœ… Passed checks (2 passed)
Check name Status Explanation
Title check βœ… Passed The title clearly describes the bug being fixed: page does not refresh after timezone switch. It directly relates to the main change in the changeset.
Docstring Coverage βœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


πŸ“œ Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

πŸ“₯ Commits

Reviewing files that changed from the base of the PR and between b974c41 and 07497d2.

πŸ“’ Files selected for processing (1)
  • packages/effects/layouts/src/basic/layout.vue
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/effects/layouts/src/basic/layout.vue
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: Lint (ubuntu-latest)
  • GitHub Check: Check (ubuntu-latest)
  • GitHub Check: Check (windows-latest)
  • GitHub Check: Test (windows-latest)
  • GitHub Check: Lint (windows-latest)
  • GitHub Check: post-update (windows-latest)
  • GitHub Check: post-update (ubuntu-latest)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❀️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jinmao88
jinmao88 merged commit 343d8a1 into vbenjs:main Jan 10, 2026
10 of 14 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants