Repository navigation
Remove Circular Redirect DetectΒ #714
Description
Now that we can limit the max redirect count, I don't think mandatory detection of circular redirects is necessary. And there are indeed many website functions that rely on circular redirection (login, for example).
So I think we can remove the Circular Redirect Detect or at least add a switch.
Reacted by πΏππππ’ππ©ππ€π£ and RecordingTheSmile
Activity
tmenier commentedon Sep 15, 2022
Hmm, yes I think I agree. I could definitely see redirects A -> B -> A as part of an auth flow, and it does look like Flurl will throw if it detects that. I'll get it on the roadmap for 4.0.
Decimation commentedon Nov 14, 2022
Any updates on this? This exception is preventing me from implementing something in a project of mine. I know I can use the standard
System.Httplibrary in the meantime, but I'd like to use Flurl if possible.RecordingTheSmile commentedon Nov 14, 2022
@tmenier Are you going to remove this feature? If yes, I can submit a PR.
tmenier commentedon Nov 16, 2022
@Decimation @whl2606555 This issue wasn't a high priority relative to the roadmap. But it's an easy one, so if it's causing you pains and you're willing to use a prerelease version, I'll get it out in the next 4.0 prerelease, which I plan on working on very soon.
Decimation commentedon Nov 16, 2022
@tmenier Yes, that would be helpful.
#714 drop circular redirect check since we have an absolute max