Skip to content

Feature: Give up when make fails #951

Closed

Description

@greg0ire

Describe the feature

Here is a failing build involving this action. In this build, make fails, but then make install is executed.

I would expect the job to fail at least when make fails. Executing make install after make fails is misleading.

Please check the latest release

  • I have checked releases, and the feature is missing in the latest patch version of v2.

Underlying issue

People looking at a failing job might start by looking at make install and look for an error in it, when the actual cause of the build failure is in make.

Describe alternatives

No response

Additional context

No response

Are you willing to submit a PR?

No

Activity

  1. shivammathur commented on May 18, 2025

    @shivammathur
    Owner

    Implemented in 9c22be2

  2. shivammathur commented on Jun 10, 2025

    @shivammathur
    Owner

    Released in 2.34.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions