Skip to content

New Excel, Dictionary and Datatable commands - #175

Merged
saucepleez merged 14 commits into
saucepleez:development-branchfrom
mbhatti125:development-branch
Dec 30, 2019
Merged

saucepleez merged 14 commits into
saucepleez:development-branchfrom
mbhatti125:development-branch

Conversation

@mbhatti125

Copy link
Copy Markdown
Contributor

No description provided.

@saucepleez

Copy link
Copy Markdown
Owner

@mbhatti125

Thank you for submitting this PR. I have taken a look and have a few comments:

Excel Get Range - We can probably merge these two into 1 command and add an additional parameter for Output (DataTable, Delimited String) or something similar to that.

Load Dictionary - Can you put together a sample script showing how it is used? I was not sure how to check against the dictionary. Additionally we could break this out into its own group "Dictionary Commands" and have commands like "Create Dictionary", "Load Dictionary (from txt, csv, excel, json)" "Add Dictionary Item" and "Get Dictionary Item".

DataTable Commands - Can you put together sample script showing how it is used? Additionally, would like to shorten the names to "Add DataRow" and "Remove DataRow" as its causing a scrollbar on render. Lastly, in the "Create DataTable" and others, we can use a datagridview and a datatable to seperate out each column name as a row instead of requiring delimited strings.

What do you think?

@mbhatti125

Copy link
Copy Markdown
Contributor Author

@saucepleez
Sure these all sound like good ideas. I'll start making updates now.

@saucepleez

Copy link
Copy Markdown
Owner

@mbhatti125 Sure, let me know if you need any help with it.

@saucepleez
saucepleez merged commit d97363f into saucepleez:development-branch Dec 30, 2019
@saucepleez

Copy link
Copy Markdown
Owner

@mbhatti125 Thanks for submitting this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants