Repository navigation
Cli tool to compare commits locally #1734
Description
Activity
Hi, you don't really have to run Docker, you can either just build the website locally (using
npm run watch && cargo build -p site) or you can download a precompiled binary with the website (https://github.com/rust-lang/rustc-perf/releases).That being said, a basic CLI output wouldn't be a bad idea, we already have it for runtime benchmarks.
It should be relatively easy to implement, either by modifying the behavior of
bench_local, and adding output of the measured results, or by introducing a separate new command for this. Thecollectorcode was heavily refactored and running benchmarks from it in a new command should hopefully be relatively easy.Reacted by Nadrieril- added a commit that references this issue
on Jun 22, 2024 - added a commit that references this issue
on Jun 23, 2024 I think we can close this because the
bench_cmpcommand is implemented and it's ported into the bootstrap. Of course we should improve the functionality though.Reacted by NadrierilAgreed 👍
Reacted by Shina
Hi! I tend to work on performance-sensitive parts of the compiler so I check performance locally a lot. In the current setup this requires me to run a docker script and check a website page. It would make my life much easier if I could run say
rustc-perf compare <commita> <commitb> instructions:uand get out the little table of relevant benchmark diffs. Would that be easy to implement?