Repository navigation
Update compiler-builtins and enable f128 tests on all non-buggy platforms - #132434
Conversation
|
rustbot has assigned @workingjubilee. Use |
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. |
|
Those are quite a few try jobs but it still doesn't cover everything that will be newly enabled here. @bors rollup=never |
Enable f128 tests on all non-buggy platforms 🎉 With the `compiler-builtins` update to 0.1.137 [1], we now provide symbols necessary to work with `f128` everywhere. This means that we are no longer restricted to 64-bit linux, and can enable tests by default. There are still a handful of platforms that need to remain disabled because of bugs. Math support is still off by default since those symbols are not yet available. [1]: rust-lang#132433 try-job: arm-android try-job: armhf-gnu try-job: i686-gnu try-job: x86_64-apple-1 try-job: i686-mingw try-job: x86_64-msvc-ext
|
Also cc @beetrees |
|
☀️ Try build successful - checks-actions |
|
This has a merge conflict, it seems. |
15075bf to
95998ee
Compare
|
I have rebased it. |
|
I think the Also |
|
I do not believe we run the relevant tests on mips64? |
|
I decided to change up the suite of tests slightly and rerun this. In particular, I noticed we didn't run the infamous @bors try |
Enable f128 tests on all non-buggy platforms 🎉 With the `compiler-builtins` update to 0.1.137 [1], we now provide symbols necessary to work with `f128` everywhere. This means that we are no longer restricted to 64-bit linux, and can enable tests by default. There are still a handful of platforms that need to remain disabled because of bugs. Math support is still off by default since those symbols are not yet available. [1]: rust-lang#132433 try-job: armhf-gnu try-job: i686-gnu try-job: i686-gnu-nopt try-job: test-various try-job: dist-mips-linux try-job: dist-mips64el-linux
This comment has been minimized.
This comment has been minimized.
All MIPS targets are tier 3, so no builds or tests of any kind are run by |
Update compiler_builtins to 0.1.138 and pin it. This updates to a new version of builtins that includes 1, which was
the last blocker to us enabling
f128tests on all platforms.With that, we now provide symbols necessary to work with
f128everywhere. This means that we are no longer restricted to systems that providef128symbols themselves, and can enable tests by default.There are still a handful of platforms that need to remain disabled because of bugs and some that had to get updated.
Math support is still off by default since those symbols are not yet available.
try-job: test-various
try-job: i686-gnu-nopt