Skip to content

Mark Hasher::finish as #[must_use] - #127055

Merged
bors merged 1 commit into
rust-lang:masterfrom
shepmaster:hash-finish-must-use
Jun 29, 2024
Merged

bors merged 1 commit into
rust-lang:masterfrom
shepmaster:hash-finish-must-use

Conversation

@shepmaster

Copy link
Copy Markdown
Member

No description provided.

@rustbot

rustbot commented Jun 27, 2024

Copy link
Copy Markdown
Collaborator

r? @joboet

rustbot has assigned @joboet.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Jun 27, 2024
@joboet

joboet commented Jun 28, 2024

Copy link
Copy Markdown
Member

Makes sense to me, but
r? libs-api

@rustbot rustbot added the T-libs-api [DEPRECATED; DO NOT USE] label Jun 28, 2024
@rustbot rustbot assigned dtolnay and unassigned joboet Jun 28, 2024

@dtolnay dtolnay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay

dtolnay commented Jun 28, 2024

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jun 28, 2024

Copy link
Copy Markdown
Collaborator

📌 Commit 448dd30 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 28, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 28, 2024
…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#123714 (Add test for fn pointer duplication.)
 - rust-lang#124091 (Update AST validation module docs)
 - rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default)
 - rust-lang#127016 (docs: check if the disambiguator matches its suffix)
 - rust-lang#127029 (Fix Markdown tables in platform-support.md)
 - rust-lang#127032 (Enable const casting for `f16` and `f128`)
 - rust-lang#127055 (Mark Hasher::finish as #[must_use])
 - rust-lang#127068 (Stall computing instance for drop shim until it has no unsubstituted const params)
 - rust-lang#127070 (add () to the marker_impls macro for ConstParamTy)
 - rust-lang#127071 (Remove (deprecated & unstable) {to,from}_bits pointer methods)
 - rust-lang#127078 (Enable full tools and profiler for LoongArch Linux targets)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 29, 2024
…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#123714 (Add test for fn pointer duplication.)
 - rust-lang#124091 (Update AST validation module docs)
 - rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default)
 - rust-lang#127016 (docs: check if the disambiguator matches its suffix)
 - rust-lang#127029 (Fix Markdown tables in platform-support.md)
 - rust-lang#127032 (Enable const casting for `f16` and `f128`)
 - rust-lang#127055 (Mark Hasher::finish as #[must_use])
 - rust-lang#127068 (Stall computing instance for drop shim until it has no unsubstituted const params)
 - rust-lang#127070 (add () to the marker_impls macro for ConstParamTy)
 - rust-lang#127071 (Remove (deprecated & unstable) {to,from}_bits pointer methods)
 - rust-lang#127078 (Enable full tools and profiler for LoongArch Linux targets)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 29, 2024
…iaskrgr

Rollup of 11 pull requests

Successful merges:

 - rust-lang#123714 (Add test for fn pointer duplication.)
 - rust-lang#124091 (Update AST validation module docs)
 - rust-lang#127015 (Switch back `non_local_definitions` lint to allow-by-default)
 - rust-lang#127016 (docs: check if the disambiguator matches its suffix)
 - rust-lang#127029 (Fix Markdown tables in platform-support.md)
 - rust-lang#127032 (Enable const casting for `f16` and `f128`)
 - rust-lang#127055 (Mark Hasher::finish as #[must_use])
 - rust-lang#127068 (Stall computing instance for drop shim until it has no unsubstituted const params)
 - rust-lang#127070 (add () to the marker_impls macro for ConstParamTy)
 - rust-lang#127071 (Remove (deprecated & unstable) {to,from}_bits pointer methods)
 - rust-lang#127078 (Enable full tools and profiler for LoongArch Linux targets)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit afde848 into rust-lang:master Jun 29, 2024
@rustbot rustbot added this to the 1.81.0 milestone Jun 29, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 29, 2024
Rollup merge of rust-lang#127055 - shepmaster:hash-finish-must-use, r=dtolnay

Mark Hasher::finish as #[must_use]
@shepmaster
shepmaster deleted the hash-finish-must-use branch June 29, 2024 12:22
celinval added a commit to celinval/rust-dev that referenced this pull request Jul 17, 2024
5e4edba Rollup merge of rust-lang#127789 - Sword-Destiny:master, r=petrochenkov
686f75b Rollup merge of rust-lang#127047 - tspiteri:f128-aconsts-lsd, r=tgross35
8b1d874 deny unsafe_op_in_unsafe_fn for teeos
f8bb325 clean unsafe op in unsafe fn
b597017 clean unsafe op in unsafe fn
9fd9c61 clean unsafe op in unsafe fn
e0c57e4 delete #![allow(unsafe_op_in_unsafe_fn)]
a778c83 Auto merge of rust-lang#127777 - matthiaskrgr:rollup-qp2vkan, r=matthiaskrgr
6535591 Rollup merge of rust-lang#124921 - RalfJung:offset-from-same-addr, r=oli-obk
ac443f2 Auto merge of rust-lang#127020 - tgross35:f16-f128-classify, r=workingjubilee
eae9451 Rollup merge of rust-lang#127750 - ChrisDenton:safe-unsafe-unsafe, r=workingjubilee
6257980 Rollup merge of rust-lang#127744 - workingjubilee:deny-unsafe-op-in-std, r=jhpratt
05614f3 Rollup merge of rust-lang#127712 - ChrisDenton:raw-types, r=workingjubilee
14c24b1 Mark some `f16` and `f128` functions unstably const
1b70afd Move safety comment outside unsafe block
3c286d5 Make os/windows default to deny unsafe in unsafe
d96ed86 Make pal/windows default to deny unsafe in unsafe
bb3f60f Fix Windows 7
9fc6710 Auto merge of rust-lang#127719 - devnexen:math_log_fix_solill, r=Amanieu
decdb06 Don't re-export `c_int` from `c`
a1a1c6a Remove DWORD
7d18991 Remove ULONG
d89bce6 Remove PSRWLOCK
d3205de Remove LPVOID
68ac381 Remove LPSECURITY_ATTRIBUTES
6d037b8 Remove LPOVERLAPPED
61f617d Remove LPCVOID
8a25371 Remove SIZE_T
cd51de1 Remove CHAR
00a5b3b Remove USHORT
d621d21 Remove LPWSTR
0b22ecb Remove UINT
18adcef Remove LONG
4eaaf7d Remove LARGE_INTEGER
aa45985 Remove NonZeroDWORD
d7aa7cf Auto merge of rust-lang#127732 - GrigorenkoPV:teeos-safe-sys-init, r=Amanieu
5ff7b40 std: Unsafe-wrap std::sync
e8fa3ef std: Unsafe-wrap in Wtf8 impl
8c3a9c1 std: Unsafe-wrap std::io
91b7331 std: Directly call unsafe {un,}setenv in env
8c75111 std: Unsafe-wrap OSStr{,ing}::from_encoded_bytes_unchecked
4679f9a std: Unsafe-wrap HashMap::get_many_unchecked_mut
ac0fd27 std: deny(unsafe_op_in_unsafe_fn) but allow sites
f710e38 Add `classify` and related methods for `f16` and `f128`
009660d std: removes logarithms family function edge cases handling for solaris.
3492a6b Auto merge of rust-lang#127728 - matthiaskrgr:rollup-ercdbjd, r=matthiaskrgr
0873299 sys::init is not unsafe on teeos
6c4029a Rollup merge of rust-lang#127592 - tesuji:patch-1, r=Mark-Simulacrum
7cd8086 Auto merge of rust-lang#125935 - madsmtm:merge-os-apple, r=workingjubilee
cfb0556 Merge Apple `std::os` extensions modules into `std::os::darwin`
54435f7 Rollup merge of rust-lang#127704 - workingjubilee:fixup-better-than, r=ChrisDenton
e122949 Auto merge of rust-lang#127706 - workingjubilee:rollup-d07ij30, r=workingjubilee
3033120 Rollup merge of rust-lang#127659 - saethlin:manually-drop-bufwriter, r=joboet
e9eb7de Rollup merge of rust-lang#127446 - zachs18:miri-stdlib-leaks-core-alloc, r=Mark-Simulacrum
3ad2560 Rollup merge of rust-lang#127370 - ChrisDenton:win-sys, r=Mark-Simulacrum
05bf6bc doc: Suggest `str::repeat` over `iter::repeat().take().collect()`
96e8ba7 Fix minor typos in std::process doc on Win argv
6b67c66 Auto merge of rust-lang#126958 - dtolnay:u32char, r=Mark-Simulacrum
591aaaf std::unix::fs: removing, now useless, layers predating macOs 10.10.
94ec6e7 Auto merge of rust-lang#127674 - jhpratt:rollup-0dxy3k7, r=jhpratt
a7c1f60 Rollup merge of rust-lang#127668 - spencer3035:improve-slice-doc, r=jhpratt
1e49e05 Rollup merge of rust-lang#127661 - eduardosm:stabilize-io_slice_advance, r=cuviper
c79e003 Auto merge of rust-lang#127397 - jyn514:multi-thread-panic-hook, r=workingjubilee
206678c Auto merge of rust-lang#126606 - zachs18:patch-2, r=joboet
1bb0350 Updated slice documentation
c8b79dd Use ManuallyDrop in BufWriter::into_parts
6e26e27 Stabilize io_slice_advance
cac6664 Rename the internal `const_strlen` to just `strlen`
39647ab fix interleaved panic output
0476fc4 Rollup merge of rust-lang#127433 - dtolnay:conststrlen, r=workingjubilee
f66bd5f Rollup merge of rust-lang#126827 - the8472:pidfd-spawn, r=workingjubilee
1e5cd21 Rollup merge of rust-lang#124980 - zachs18:rc-allocator, r=Amanieu
949f0d6 Add instability attribute on private const_strlen function
20bfac6 Rollup merge of rust-lang#127422 - greaka:master, r=workingjubilee
f937ef1 Rollup merge of rust-lang#127599 - tgross35:lazy_cell_consume-rename, r=workingjubilee
fde7fd2 Rollup merge of rust-lang#127588 - uweigand:s390x-f16-doctests, r=tgross35
ed47f98 Rollup merge of rust-lang#127572 - tbu-:pr_debug_event_nonpacked, r=jhpratt
e5c8b85 Rollup merge of rust-lang#124599 - estebank:issue-41708, r=wesleywiser
b71b538 Rename `lazy_cell_consume` to `lazy_cell_into_inner`
9efc1cb core: Limit remaining f16 doctests to x86_64 linux
a18fbd0 Rollup merge of rust-lang#127554 - ferrocene:tshepang-add-missing-attribute, r=pietroalbini
e419147 Don't mark `DEBUG_EVENT` struct as `repr(packed)`
4552576 Auto merge of rust-lang#126690 - andyolivares:feature/show_window, r=dtolnay
6f6e343 Rollup merge of rust-lang#127091 - Sky9x:fused-error-sources-iter, r=dtolnay
0d64105 Fixed doc links
4fb7b22 Few changes to doc comments. Added tracking issue number.
fe62f6f Exposing STARTUPINFOW.wShowWindow in CommandExt (show_window function) to control how a new process should display its window (normal, minimized, maximized, etc)
7d20047  do not run test where it cannot run
c5f1c76 Auto merge of rust-lang#127235 - martn3:no-mips-f16, r=tgross35,scottmcm
3fefa04 Rollup merge of rust-lang#127460 - Borgerr:clarify-drop-comment, r=jhpratt
895175a Rollup merge of rust-lang#127355 - aceArt-GmbH:126475, r=oli-obk
57cea32 Rollup merge of rust-lang#120248 - WaffleLapkin:bonk-ptr-object-casts, r=compiler-errors,oli-obk,lnicola
e74955e Attempt to fix CI
e466bf5 Rollup merge of rust-lang#127367 - ChrisDenton:run-sync, r=Nilstrieb
90504f8 Rollup merge of rust-lang#126921 - workingjubilee:outline-va-list, r=Nilstrieb
c6b3f3d Auto merge of rust-lang#127454 - matthiaskrgr:rollup-k3vfen2, r=matthiaskrgr
29d7923 Move/change declaration of `mod exit_guard;`
ecc9025 clarify `sys::unix::fd::FileDesc::drop` comment (rust-lang#66876)
35c5a45 Rollup merge of rust-lang#127447 - RalfJung:once_lock_miri, r=joboet
9f7100d Rollup merge of rust-lang#127354 - nicholasbishop:bishop-sized-doc, r=Nilstrieb
ee06e7d Rollup merge of rust-lang#127297 - the8472:path-new-hash, r=Nilstrieb
2206c6b Rollup merge of rust-lang#127189 - GrigorenkoPV:linkedlist-cursor-list, r=Nilstrieb
41bcc36 Rollup merge of rust-lang#127179 - tgross35:typeid-debug-hex, r=Nilstrieb
7177ac8 once_lock: make test not take as long in Miri
294d87f Remove non-focused memory leak in `std` doctest for Miri.
a86fd0f Specialize `TrustedLen` for `Iterator::unzip()`
5515bba Mitigate focused memory leaks in `core` doctests for Miri.
3a0fe26 Remove non-focused memory leaks in `core` doctests for Miri.
20d6cb3 Mitigate focused memory leaks in `alloc` doctests for Miri.
cac8902 Remove non-focused memory leaks in `alloc` doctests for Miri.
bcdc8e8 Stabilize const_cstr_from_ptr (CStr::from_ptr, CStr::count_bytes)
a48f566 offset_from intrinsic: always allow pointers to point to the same address
9919a83 Mark format! with must_use hint
0907955 as_simd: fix comment to be in line with 507583a (rust-lang#121201)
5569ece Rollup merge of rust-lang#127275 - RalfJung:offset-from-isize-min, r=Amanieu
2337ab5 Rollup merge of rust-lang#125751 - pitaj:new_range_api, r=jhpratt
ad4fde6 Rollup merge of rust-lang#127363 - GuillaumeGomez:improve-fmt-code-readability, r=Amanieu
3eeca5f Rollup merge of rust-lang#127107 - mu001999-contrib:dead/enhance-2, r=pnkfelix
1b5e5ac Rollup merge of rust-lang#123600 - tisonkun:path_with_extension, r=dtolnay
5e9d445 Attempt to fix CI
d8965d3 add `new_range_api` for RFC 3550
ca0f659 Move exit guard from sys::common::exit_guard to sys::exit_guard.
cf300a7 Update library/std/src/sys/pal/common/exit_guard.rs
ba4c71a add unit tests for extra extension feature
55fc20b update comments
6b7a259 Add experimental raw-dylib feature to std
c452e62 Use windows_targets macro for alloc
521c81a Run alloc sync tests
2fcdebb Improve readability of some fmt code examples
625bcc4 Rollup merge of rust-lang#127320 - ChrisDenton:win-sys, r=Mark-Simulacrum
f8caf5f Rollup merge of rust-lang#127214 - bjorn3:miri_native_unwind, r=oli-obk
1862054 Describe Sized requirements for mem::offset_of
e26c881 impl FusedIterator and a size hint for the error sources iter
8f1c664 core: erase redundant stability attrs in va_list
60c33a5 library: outline VaList into ffi::va_list
03d11c2 Auto merge of rust-lang#126171 - RalfJung:simd_bitmask_multibyte, r=workingjubilee
297850a Add more checks for pointers with vtable meta
f58a3d6 Improve dead code analysis
515bd30 Add comments to windows_targets.rs
89d2de0 Update windows-bindgen to 0.58.0
0860a04 also remove redundant requirements from offset()
6f80604 offset_from: "the difference must fit in an isize" is a corollary
de4f5c2 Rollup merge of rust-lang#127303 - cuishuang:master, r=jhpratt
56c73c3 Rollup merge of rust-lang#127195 - biabbas:vxworks_cleanup, r=jhpratt
5dfdef7 Rollup merge of rust-lang#126792 - wooden-worm:master, r=Mark-Simulacrum
4df2059 chore: remove repeat words
acbefbb impl PathBuf::add_extension and Path::with_added_extension
13d5a42 Auto merge of rust-lang#127226 - mat-1:optimize-siphash-round, r=nnethercote
ed3d487 stir the hash state a little to avoid prefix collisions
5ca124f Add more test cases for path comparisons
33bc557 Add test case demonstrating equality of paths "foo/bar" and "foobar"
079f999 Move unique_thread_exit call to lang_start_internal so it is not in a generic function, and wrap it in `catch_unwind`
47d0cbc Remove Miri special-case
596be7e Use pthread_t instead of numeric thread id
2e90f6f Use libc::pause instead of std::thread::park in wait-for-exit loop
1fd23e8 core: Limit four f16 doctests to x86_64 linux
e6f15c5 std: Set has_reliable_f16 to false for MIPS targets in build.rs
67535b6 library/std/build.rs: "powerpc64le" is not a target_arch
5b0d82f Rollup merge of rust-lang#127204 - dimpolo:stabilize_atomic_bool_fetch_not, r=jhpratt
b184a84 Rollup merge of rust-lang#123588 - tgross35:stabilize-assert_unchecked, r=dtolnay
2a81053 Fall back on remove dir implementation for vxworks
a8b6d0a Rollup merge of rust-lang#127230 - hattizai:patch01, r=saethlin
4d7cbb2 chore: remove duplicate words
645e9f2 Optimize SipHash by reordering compress instructions
c5ab1f0 Rollup merge of rust-lang#127128 - elomatreb:elomatreb/stabilize-duration_abs_diff, r=joboet
f090672 Rollup merge of rust-lang#126732 - StackOverflowExcept1on:master, r=m-ou-se
1dc4f05 Use the native unwind function in miri where possible
4fff335 Avoid MIR bloat in inlining
4385efd Stabilize atomic_bool_fetch_not
6c3359c Rollup merge of rust-lang#127182 - danielhuang:patch-4, r=Nilstrieb
a0a438a Remove unqualified import io:: Error for vxworks as all Error references are qualified in process_vxworks.rs
2a65e9f Auto merge of rust-lang#127026 - Urgau:cleanup-bootstrap-check-cfg, r=Kobzol
bba2200 LinkedList's Cursor: method to get a ref to the cursor's list
40a9be9 Update ip_addr.rs
986dbd1 Print `TypeId` as hex for debugging
f27723e Rollup merge of rust-lang#127069 - Sky9x:fmt-pointer-use-addr, r=Nilstrieb
b068fce Rollup merge of rust-lang#126895 - betelgeuse:improve_simd_gather_documentation, r=Amanieu
a6b22e9 Rollup merge of rust-lang#127134 - tgross35:typeid-debug, r=Nilstrieb
7f0bb45 Rollup merge of rust-lang#126906 - GrigorenkoPV:fixme-split_at_first, r=Mark-Simulacrum
b0feb54 Rollup merge of rust-lang#126705 - safinaskar:panic, r=Mark-Simulacrum
b8977f5 Auto merge of rust-lang#127133 - matthiaskrgr:rollup-jxkp3yf, r=matthiaskrgr
affa2f9 Print `TypeId` as a `u128` for `Debug`
05a472c Rollup merge of rust-lang#127122 - TDecking:div_ceil, r=Nilstrieb
9b3a511 Auto merge of rust-lang#120639 - fee1-dead-contrib:new-effects-desugaring, r=oli-obk
f96a321 Stabilize `duration_abs_diff`
bf9096f small correction to fmt::Pointer impl
171f5db Auto merge of rust-lang#127121 - GuillaumeGomez:rollup-xjjjckn, r=GuillaumeGomez
50a6646 Remove uneccessary condition in `div_ceil`
7914389 Updated docs on `#[panic_handler]` in `library/core/src/lib.rs`
1858bdc Rollup merge of rust-lang#127073 - Sky9x:unnecessary-seqcst, r=Nilstrieb
aaed209 Rollup merge of rust-lang#127072 - Sky9x:docs-includes-vs-does-include, r=scottmcm
e5a577d Auto merge of rust-lang#127119 - RalfJung:miri-sync, r=RalfJung
77a5b51 Rollup merge of rust-lang#126953 - joboet:lazy_key, r=jhpratt
8641f6a Merge from rustc
402992c Rollup merge of rust-lang#127071 - Sky9x:remove-ptr-to-from-bits, r=scottmcm
0a2d8e4 Rollup merge of rust-lang#127070 - Sky9x:unit-const-param-ty, r=BoxyUwU
663f3d5 Rollup merge of rust-lang#127055 - shepmaster:hash-finish-must-use, r=dtolnay
729a10a address review comments
db228b8 general fixups and turn `TODO`s into `FIXME`s
47492c9 Implement `Min` trait in new solver
cc4a029 implement new effects desugaring
d6fadf5 std: add safety comments
8c3c7dc Rollup merge of rust-lang#126970 - DaniPopes:simplify-str-clone_into, r=cuviper
ae98528 Rollup merge of rust-lang#126956 - joboet:fmt_no_extern_ty, r=RalfJung
652f0b8 Merge from rustc
48dc678 Remove unnecessary SeqCst in `impl fmt::Pointer for AtomicPtr`
e6e5e84 docs: say "includes" instead of "does include"
a722d39 Remove (deprecated & unstable) {to,from}_bits pointer methods
2ed9c9f add () to the marker_impls macro for ConstParamTy
fdfe014 Mark `Hasher::finish` as #[must_use]
2bd2069 fix least significant digits of f128 associated constants
8db57c2 core: improve comment
1f8c8f4 Cleanup bootstrap check-cfg
6c38c60 Rollup merge of rust-lang#126980 - Borgerr:fix-extendfromslice-check, r=workingjubilee
a2dc9b5 Rollup merge of rust-lang#126929 - nnethercote:rm-__rust_force_expr, r=oli-obk
cf231e8 Merge from rustc
a8b311e Auto merge of rust-lang#126608 - tgross35:f16-f128-library, r=Mark-Simulacrum
4788a93 std: test a variety of ways to extend a Wtf8Buf
57c2de8 set self.is_known_utf8 to false in extend_from_slice
c14a130 Rollup merge of rust-lang#126879 - the8472:next-chunk-filter-drop, r=cuviper
f6fdef3 core: avoid `extern` types in formatting infrastructure
43a865a fix UI test, simplify error message
ff33a66 regression test for leaks in the the Filter::next_chunk implementation