Skip to content

target_env should not include ABI information #78791

Description

@cuviper

There are a few tier-3 targets that have ABI descriptors in their target_env.

compiler/rustc_target/src/spec/armv6_unknown_freebsd.rs:13:        target_env: "gnueabihf".to_string(),
compiler/rustc_target/src/spec/armv6_unknown_netbsd_eabihf.rs:14:        target_env: "eabihf".to_string(),
compiler/rustc_target/src/spec/armv7_unknown_freebsd.rs:13:        target_env: "gnueabihf".to_string(),
compiler/rustc_target/src/spec/armv7_unknown_netbsd_eabihf.rs:13:        target_env: "eabihf".to_string(),

The precedent from other targets is that these should be just "gnu" or an empty string. This came up in the RFC for target_abi, rust-lang/rfcs#2992 (comment), where I'd expect these targets will have target_abi: "eabihf".

Activity

  1. added
    O-ArmTarget: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 state
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    O-freebsdOperating system: FreeBSD
    O-netbsdOperating system: NetBSD
    A-target-specsArea: Compile-target specifications
    C-bugCategory: This is a bug.
    on Nov 5, 2020
  2. added a commit that references this issue on Feb 25, 2024
    e13f454
  3. added a commit that references this issue on Feb 25, 2024
    fd342c1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-target-specsArea: Compile-target specificationsC-bugCategory: This is a bug.O-ArmTarget: 32-bit Arm processors (armv6, armv7, thumb...), including 64-bit Arm in AArch32 stateO-freebsdOperating system: FreeBSDO-netbsdOperating system: NetBSDT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions