Skip to content

Repeated spurious rustdoc test failure: rustdoc-gui/help-page #126430

Closed
Closed
Repeated spurious rustdoc test failure: rustdoc-gui/help-page#126430
Labels
A-CIArea: Our Github Actions CIA-spuriousArea: Spurious failures in builds (spuriously == for no apparent reason)A-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Description

@RalfJung
RalfJung
opened on Jun 13, 2024

I've seen this fail in two PRs today, e.g. here

  /checkout/tests/rustdoc-gui/help-page.goml help-page... FAILED
  Error:  `tests/rustdoc-gui/utils.goml` line 16
      from `tests/rustdoc-gui/help-page.goml` line 23
      from `tests/rustdoc-gui/help-page.goml` line 32: Error: Evaluation failed: The following errors happened: [localStorage item "rustdoc-theme" (of value "ayu") != "null"]: for command `assert-local-storage: {"rustdoc-theme": |theme|}`

Cc @rust-lang/rustdoc

Activity

  1. rustbot
    added
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Jun 13, 2024
  2. Noratrieb
    added
    A-testsuiteArea: The testsuite used to check the correctness of rustc
    T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.
    A-spuriousArea: Spurious failures in builds (spuriously == for no apparent reason)
    C-bugCategory: This is a bug.
    A-CIArea: Our Github Actions CI
    and removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Jun 13, 2024

  3. GuillaumeGomez commented on Jun 13, 2024

    @GuillaumeGomez
    GuillaumeGomez
    on Jun 13, 2024
    Member

    Taking a look.

  4. matthiaskrgr
    added a commit that references this issue on Jun 13, 2024

    Rollup merge of rust-lang#126436 - GuillaumeGomez:reduce-gui-tests-fl…

    6483e65

  5. GuillaumeGomez commented on Jul 17, 2024

    @GuillaumeGomez
    GuillaumeGomez
    on Jul 17, 2024
    Member

    It was "fixed" in #127082 (still no idea why this test in particular is failing).

  6. GuillaumeGomez
    closed this as completedon Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-CIArea: Our Github Actions CIA-spuriousArea: Spurious failures in builds (spuriously == for no apparent reason)A-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions