Skip to content

regression: f16 + f128 is unstable #123282

Closed
Closed
regression: f16 + f128 is unstable#123282
Labels
A-resolveArea: Name/path resolution done by `rustc_resolve` specificallyC-bugCategory: This is a bug.F-f16_and_f128`#![feature(f16)]`, `#![feature(f128)]`P-highHigh priorityS-has-mcveStatus: A Minimal Complete and Verifiable Example has been found for this issueT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.
Milestone
1.78.0

Description

@Mark-Simulacrum
Mark-Simulacrum
opened on Mar 31, 2024
[INFO] [stdout] error[E0658]: the type `f16` is unstable
[INFO] [stdout]  --> src/float.rs:5:9
[INFO] [stdout]   |
[INFO] [stdout] 5 | pub use f16::*;
[INFO] [stdout]   |         ^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: see issue #116909 <https://github.com/rust-lang/rust/issues/116909> for more information

Activity

  1. Mark-Simulacrum
    added
    regression-from-stable-to-betaPerformance or correctness regression from stable to beta.
    on Mar 31, 2024
  2. Mark-Simulacrum
    added this to the 1.78.0 milestone on Mar 31, 2024
  3. rustbot
    added
    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Mar 31, 2024
  4. Mark-Simulacrum
    changed the title [-]regression: f16 is unstable[/-] [+]regression: f16 + f128 is unstable[/+] on Mar 31, 2024
  5. fmease
    added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    and removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Mar 31, 2024

  6. fmease commented on Mar 31, 2024

    @fmease
    fmease
    on Mar 31, 2024
    Member

    cc @tgross35

  7. Noratrieb commented on Mar 31, 2024

    @Noratrieb
    Noratrieb
    on Mar 31, 2024
    Member

    MCVE:

    mod f16 { pub fn a() {} }

pub use f16::a;

  8. Noratrieb commented on Mar 31, 2024

    @Noratrieb
    Noratrieb
    on Mar 31, 2024
    Member

    It compiles if I add #![feature(f16)]. Somehow feature gating and name resolution disagree whether it refers to the type or the module.

    mod f32 { pub fn a() {} }

pub use f32::a;

    also compiles

  9. Noratrieb
    added
    C-bugCategory: This is a bug.
    F-f16_and_f128`#![feature(f16)]`, `#![feature(f128)]`
    on Mar 31, 2024

  10. Noratrieb commented on Mar 31, 2024

    @Noratrieb
    Noratrieb
    on Mar 31, 2024
    Member

    I think this was fixed recently? It reproduces on the playground nightly, but does not reproduce on the latest nightly and on master.

  11. Noratrieb commented on Mar 31, 2024

    @Noratrieb
    Noratrieb
    on Mar 31, 2024
    Member

    Ah no, I can reproduce it with cargo build, just not with rustc directly (?????????).

  12. Noratrieb commented on Mar 31, 2024

    @Noratrieb
    Noratrieb
    on Mar 31, 2024
    Member

    cc @petrochenkov @compiler-errors, it was probably regressed by e782d27

  13. 23 remaining items

  14. tgross35 commented on Apr 4, 2024

    @tgross35
    tgross35
    on Apr 4, 2024
    Member

    Ah I shouldn't have included a fixes: tag, this needs to be reopened.

    Since the fix is small, I'll put up a beta PR with the cherry pick as long as that seems reasonable in favor of reverting.

  15. tgross35
    added 2 commits that reference this issue on Apr 4, 2024

    Update f16 and f128 tests to run on both 2015 and 2018 editions

    07ed445

    Fix f16 and f128 feature gates in editions other than 2015

    356bb13

  16. tgross35 commented on Apr 4, 2024

    @tgross35
    tgross35
    on Apr 4, 2024
    Member

    Up at #123445

  17. fmease commented on Apr 4, 2024

    @fmease
    fmease
    on Apr 4, 2024
    Member

    Ah I shouldn't have included a fixes: tag, this needs to be reopened.

  18. fmease
    reopened this on Apr 4, 2024
  19. tgross35
    added a commit that references this issue on Apr 5, 2024

    Revert "Put basic impls for f16 and f128 behind cfg(not(bootstrap))"

    79a37b6
  20. Oneirical
    added a commit that references this issue on Apr 6, 2024

    Squashed commit of the following:

    9dca894
  21. tgross35
    added 2 commits that reference this issue on Apr 7, 2024

    Revert "Put basic impls for f16 and f128 behind cfg(not(bootstrap))"

    49e39ef

    Revert "Put basic impls for f16 and f128 behind cfg(not(bootstrap))"

    420f9d4

  22. tgross35 commented on Apr 9, 2024

    @tgross35
    tgross35
    on Apr 9, 2024
    Member

    Ah I shouldn't have included a fixes: tag, this needs to be reopened.

    Well, now it can be closed again 😄 #123466 should hopefully fix this.

  23. tgross35
    added a commit that references this issue on Apr 10, 2024

    Revert "Put basic impls for f16 and f128 behind cfg(not(bootstrap))"

    88bcc79
  24. cuviper
    closed this as completedon Apr 12, 2024
  25. kjetilkjeka
    added a commit that references this issue on Apr 15, 2024

    Put basic impls for f16 and f128 behind cfg(not(bootstrap))

    a74a047
  26. Kobzol
    added a commit that references this issue on Feb 3, 2026

    Auto merge of #123390 - tgross35:f16-f128-libs-basic-impls-bootstrap,…

    674e983
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-resolveArea: Name/path resolution done by `rustc_resolve` specificallyC-bugCategory: This is a bug.F-f16_and_f128`#![feature(f16)]`, `#![feature(f128)]`P-highHigh priorityS-has-mcveStatus: A Minimal Complete and Verifiable Example has been found for this issueT-compilerRelevant to the compiler team, which will review and decide on the PR/issue.regression-from-stable-to-betaPerformance or correctness regression from stable to beta.

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions