Skip to content

feat(implement-approved-plan): add guarded delivery workflow - #7

Merged
renanfranca merged 6 commits into
mainfrom
codex/implement-approved-plan
Aug 31, 2026
Merged

renanfranca merged 6 commits into
mainfrom
codex/implement-approved-plan

Conversation

@renanfranca

@renanfranca renanfranca commented Aug 31, 2026 •

Copy link
Copy Markdown
Owner

Intent

Add the explicit-only $implement-approved-plan skill for executing an approved implementation plan through reusable specialist chats, serialized access to one checkout, auditable state, and guarded GitHub delivery.

Observable behavior

  • Requires the exact Coordinator and specialist model/effort combinations and stops without fallback.
  • Requires the effective Full access runtime profile before local task creation.
  • Persists the approved plan and an atomic workflow ledger under ignored .agent/tmp state.
  • Rejects invalid phase changes, conflicting checkout leases, premature pull requests, repeated transient CI retries, corrupt history, and cleanup without authoritative MERGED confirmation.
  • Routes TDD, commits, validation, Habit curation, structural review, CI failures, and later cleanup to their defined roles.
  • Never merges pull requests or deletes branches automatically.

Validation

  • python3 -m unittest discover -s implement-approved-plan/scripts/tests -v β€” 28 tests passed.
  • python3 -m unittest discover -s restructure-documentation/scripts/tests -v β€” 6 tests passed.
  • python3 .system/skill-creator/scripts/quick_validate.py ./implement-approved-plan β€” passed.
  • Markdown link validation for the changed skill and AGENTS.md β€” passed.
  • git diff --check β€” passed.
  • Public fixture pilot: renanfranca/implement-approved-plan-fixture#2 merged after Maven verification, green CI, Habit/PMD evaluation, and a real local SonarQube quality gate.

Coverage, Sonar, and Habit

This skills repository has no configured build, coverage, lint, or Sonar gate. The available unconfigured flake8 defaults conflict with the repository-required two-space Python indentation and are not a repository gate. Habit was recorded as not applicable for this repository. The public fixture supplied the real Maven, coverage, Habit, SonarQube, and CI pilot evidence.

Pull request checks

GitHub reports no branch protection and no rulesets for main, so there are no required checks. Four optional Netlify contexts reached a terminal failure in deploy 6a94dbb6b12880000860df6d. The same Netlify site failed on the nine preceding main deploys while the branch gates above remain green, so the Validator classified this as a systemic environment failure rather than a code or transient failure. No retry was performed.

Known risks

  • Permission profiles are host runtime state; prompts cannot grant access. The workflow fails closed when the exact effective profile is unavailable.
  • Protected cleanup depends on an authoritative GitHub MERGED response and deliberately preserves local state on ambiguous or failed queries.
  • The workflow intentionally keeps branches and ignored plan state until later merge confirmation.

@netlify

netlify Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

❌ Deploy Preview for codex-skills failed.

Name Link
πŸ”¨ Latest commit 50d185e
πŸ” Latest deploy log https://app.netlify.com/projects/codex-skills/deploys/6a94dbb6b12880000860df6d

@renanfranca
renanfranca merged commit 7db842c into main Aug 31, 2026
0 of 4 checks passed
@renanfranca
renanfranca deleted the codex/implement-approved-plan branch August 31, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant