Repository navigation
d500: add RS2_OPTION_DUAL_RGB_RECTIFICATION for D585 2C USB - #15625
Merged
Merged
Conversation
sysrsbuild-gh-agentic
left a comment
Collaborator
There was a problem hiding this comment.
Automated code review by rs-agentic bot.
alexkunin-gh
previously approved these changes
Sep 2, 2026
alexkunin-gh
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: Adds a boolean option on D585 2C USB that asks the firmware to rectify the two RGB streams.
Tracked on [RSDEV-13331]
Why
The firmware exposes its dual-RGB rectification toggle only through a custom HWM command, so there was no SDK control for it and callers had to send raw HWM bytes.
Summary
rs5x5_devicebehind a minimum-firmware check (7.58.46064.14668).CUSTOM_CMD(0x80) sub-command 0x29. Rejected while streaming — depth and both color pins share the sensor. The value is validated before it reaches firmware.Test plan
customCmdSetDualRgbRectify: 0/1,ret=0.Open items
🤖 Generated by AI