Repository navigation
Bump ws override to version 8.21.0 for security - #15526
Merged
Merged
Conversation
sysrsbuild-gh-agentic
left a comment
sysrsbuild-gh-agentic
left a comment
Collaborator
There was a problem hiding this comment.
rs-agentic bot auto-review ✅ No bugs found. Change is clean and minimal — security bump is well-motivated and test coverage confirms correctness.
Nir-Az
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
wsoverride was pinned to 8.20.1, which is the highest version still covered by GHSA-96hv-2xvq-fx4p (affected range: 8.0.0 - 8.20.1, inclusive). Bumping the override to 8.21.0 moves it out of the advisory range.This is a runtime path, not dev-only:
socket.io-client->engine.io-client->ws.Verified:
npm audit --omit=dev: 2 high -> 0 vulnerabilitiesnpm ciclean, installed ws = 8.21.0npm run buildpassesnpm test: 115/115 passThe lockfile also collapses two nested
wscopies into one hoisted entry. That dedup is not caused by this bump - the two copies held different versions when the lockfile was first tracked (8.20.0 and 8.18.3, legitimately nested), and became redundant once an override forced both edges to a single version. Anynpm installperforms the same collapse.