Repository navigation
Fix fw err test - #15502
Fix fw err test#15502
Conversation
4b55e20 to
380ad8a
Compare
|
👋 Hi @Binyaminp, this PR targets the Per our contribution guidelines, PRs should target the Please review: https://github.com/realsenseai/librealsense/blob/master/CONTRIBUTING.md
|
sysrsbuild-gh-agentic
left a comment
sysrsbuild-gh-agentic
left a comment
There was a problem hiding this comment.
🤖 Auto-generated review by rs-agentic bot
| pytestmark = [ | ||
| pytest.mark.device_each("D585"), # matches D585 and D585S (prefix match) | ||
| pytest.mark.device_each("D585S"), | ||
| pytest.mark.context("nightly"), |
There was a problem hiding this comment.
"D585" (prefix match → covers D585 and D585S) to "D585S" (exact match) silently drops test coverage for bare D585 devices. The removed comment explicitly documented this prefix-match behavior. Intentional?
🤖 Auto-generated comment by rs-agentic bot
There was a problem hiding this comment.
change approved — the pytest-stream-color.py change was reverted, addressing the D585/D585S coverage concern. 🤖 rs-agentic bot
| pytest.mark.device_each("D400*"), | ||
| pytest.mark.device_each("D500*"), | ||
| pytest.mark.device_exclude("D585 Proto"), | ||
| pytest.mark.context("nightly"), |
There was a problem hiding this comment.
ℹ️ Consider adding a comment explaining why D585 Proto is excluded (e.g. a known FW issue on proto HW), so the intent is clear when revisiting later.
🤖 Auto-generated comment by rs-agentic bot
No description provided.