Repository navigation
Viewer fix slider snapback on GMSL - #15488
Merged
Merged
Conversation
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
sysrsbuild-gh-agentic
left a comment
sysrsbuild-gh-agentic
left a comment
Collaborator
There was a problem hiding this comment.
[rs-agentic bot] Auto-generated review. Flagging potential issues below.
OhadMeir
force-pushed
the
d585_gmsl_controls
branch
from
August 2, 2026 09:25
4a59273 to
0e5b84a
Compare
remibettan
reviewed
Aug 2, 2026
remibettan
self-requested a review
August 2, 2026 13:09
remibettan
approved these changes
Aug 2, 2026
Contributor
Author
|
CI running the GUI tests LRS_libci_pipeline/17485 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Viewer: fix option slider snapping back to the old value on slow write/echo devices (D585 GMSL)
Drop the "user just set" slider mask on the actual FW-write-completed event (did_write), refreshing the cached value then — instead of a fixed 500 ms/1000 ms timer that can outpace a slow MIPI write/echo.
Periodic refreshers (update_all_fields/update_value) now hold the requested value while a write is pending, with the existing 2 s fallback and FW-error path preserved.
Eliminates the new→old→new flicker on GMSL; behavior on USB is unchanged (write lands fast).