Repository navigation
d500: hide AE-Setpoint control in viewer and reject it via advanced-mode API - #15421
Merged
Nir-Az merged 1 commit intoJul 21, 2026
Merged
Conversation
…ode API AE-Setpoint (STAEControl::meanIntensitySetPoint) only applies to the D400 AE V1 algorithm; D500-family devices use a different enhanced Depth AE that ignores it, so the value silently had no effect. Hide the slider in the viewer's Advanced Mode dialog and make set_ae_control() throw for D500 product line so non-UI callers get an explicit error instead of a silent no-op.
Nir-Az
approved these changes
Jul 21, 2026
|
|
||
| void ds_advanced_mode_base::set_ae_control( const STAEControl & val ) | ||
| { | ||
| if( _dev->get_info( rs2_camera_info::RS2_CAMERA_INFO_PRODUCT_LINE ) == "D500" ) |
Collaborator
There was a problem hiding this comment.
Please make sure on D400 and D500
Visual preset change on viewer works well
Need to make sure this function is not called
Merged
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: Hides the AE-Setpoint (Mean Intensity Set Point) control for D500-family devices in the RealSense Viewer, and makes the advanced-mode API reject it explicitly instead of silently no-op'ing.
Tracked on [RSDEV-12601]
Why
AE-Setpoint (
STAEControl::meanIntensitySetPoint) only applies to the D400 AE V1 algorithm. D500-family devices (D555, D585, etc.) use a different enhanced/HKR Depth AE that ignores it, so changing the value from the viewer had no visible effect and read as a bug to customers (see RSDEV-11758).Summary
_is_d500_devicecheck (previously only D457 was excluded).ds_advanced_mode_base::set_ae_control()now throws for D500 product-line devices, so callers going through the C/C++ advanced-mode API directly (not just the viewer) get an explicit error instead of a silent no-op.Test plan
realsense2andrealsense-viewer(Release, MSVC) successfully with the change.set_ae_control()throws when called on a D500-family device via the API.🤖 Generated by AI