Skip to content

viewer: fix post-processing filter controls reverting to default value (cherry-pick #15330) - #15345

Merged
Nir-Az merged 1 commit into
realsenseai:r/2.58.3from
Nir-Az:postproc-sync-r2583
Jul 2, 2026
Merged

Nir-Az merged 1 commit into
realsenseai:r/2.58.3from
Nir-Az:postproc-sync-r2583

Conversation

@Nir-Az

@Nir-Az Nir-Az commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Overview: Cherry-pick of #15330 to the 2.58.3 release branch — in the viewer, a post-processing filter control (e.g. decimation magnitude, rotation) applied the effect but the control snapped back to its previous value; it now stays at the value the user set.

Tracked on [RSDEV-12488], [RSDEV-12502]

Why

Regression from PR #15029 (async UI option writes) present in 2.58.3. Software post-processing filters emit no on_options_changed echo, so the control's cached value was never refreshed after the write and reverted once the ~2 s user-request mask expired (the effect applied, but the slider snapped back).

Summary

  • Cherry-pick of viewer: fix post-processing filter controls reverting to default value #15330 (merge cf8648a26), clean apply, no conflicts.
  • Software post-processing filter options write synchronously (value read back → no revert); FW/sensor options stay async.
  • Includes the review follow-ups: reset last_user_set_stopwatch on sync writes, scope the invalidate gate to a local error buffer, and a viewer UI regression test.

Test plan

  • Verified on development: viewer UI test post_processing_value_persists passes on D455; confirmed live in the viewer; ran in nightly (gui+nightly context).
  • CI on this cherry-pick PR.

🤖 Generated by AI

@sysrsbuild-gh-agentic sysrsbuild-gh-agentic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[rs-agentic bot] Automated review of cherry-pick #15345 to r/2.58.3.

The fix is sound: routing software-filter writes through a synchronous path with immediate readback directly addresses the root cause (no on_options_changed echo -> stale cache -> revert). Overall the approach is correct. Several items flagged below — see inline comments.

Comment thread common/option-model.h Resolved
Comment thread common/option-model.cpp Resolved
Comment thread common/option-model.cpp Resolved
Comment thread common/option-model.cpp Resolved
Comment thread common/processing-block-model.cpp Resolved
@Nir-Az
Nir-Az requested a review from remibettan July 2, 2026 09:36
@Nir-Az
Nir-Az merged commit dfd6aa9 into realsenseai:r/2.58.3 Jul 2, 2026
30 of 34 checks passed
@Nir-Az
Nir-Az deleted the postproc-sync-r2583 branch July 2, 2026 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants