Repository navigation
viewer: fix post-processing filter controls reverting to default value (cherry-pick #15330) - #15345
Merged
Merged
Conversation
sysrsbuild-gh-agentic
left a comment
Collaborator
There was a problem hiding this comment.
[rs-agentic bot] Automated review of cherry-pick #15345 to r/2.58.3.
The fix is sound: routing software-filter writes through a synchronous path with immediate readback directly addresses the root cause (no on_options_changed echo -> stale cache -> revert). Overall the approach is correct. Several items flagged below — see inline comments.
remibettan
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: Cherry-pick of #15330 to the 2.58.3 release branch — in the viewer, a post-processing filter control (e.g. decimation magnitude, rotation) applied the effect but the control snapped back to its previous value; it now stays at the value the user set.
Tracked on [RSDEV-12488], [RSDEV-12502]
Why
Regression from PR #15029 (async UI option writes) present in 2.58.3. Software post-processing filters emit no
on_options_changedecho, so the control's cached value was never refreshed after the write and reverted once the ~2 s user-request mask expired (the effect applied, but the slider snapped back).Summary
cf8648a26), clean apply, no conflicts.last_user_set_stopwatchon sync writes, scope the invalidate gate to a local error buffer, and a viewer UI regression test.Test plan
post_processing_value_persistspasses on D455; confirmed live in the viewer; ran in nightly (gui+nightlycontext).🤖 Generated by AI