Repository navigation
Migrate test-motion.py to pytest - #15317
Merged
Merged
Conversation
OhadMeir
reviewed
Jul 1, 2026
sysrsbuild-gh-agentic
left a comment
Collaborator
There was a problem hiding this comment.
🤖 rs-agentic automated review — reviewing the latest push (Simplify device markers to inline device_each, keep D500-series coverage).
The simplification of the block using the inline ternary is cleaner and consistent with the pattern OhadMeir suggested 👍. A few additional observations below (inline).
OhadMeir
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview: Migrates the motion-intrinsics live test (accel/gyro/combined-motion profiles) to native pytest.
Tracked on [RSDSO-21677]
Why
Part of the ongoing effort to move legacy
test-*.pyscripts to nativepytest-*.py.Summary
git mv test-motion.py pytest-motion-intrinsics.py(history preserved). Namedpytest-motion-intrinsics.py, notpytest-motion.py, to avoid a module-name collision with the existingunit-tests/sw-dev/pytest-motion.py(pytest derives the module name from the basename; twopytest-motion.pyfiles abort collection).def test_motion_intrinsics(test_device); uses thetest_devicefixture instead oftest.find_first_device_or_exit().# test:donotrun:!weekly→pytest.mark.context("weekly").is_jetson_platform(), usingdevice_eachso a bench lacking the device skips instead of failing (matchespytest-mipi-motion.py/pytest-intra-camera-sync.py):device_each("D457")device_each("D455")+device_each("D500*")from rspy import test, log→ stdliblogging;log.d→log.debug.test.check(motion_sensor)precondition →assert; remainingtest.check→pytest_check.check.is_true. Droppedtest.start/finish/print_results_and_exit.Test plan
-r motion:test_motion_intrinsicsPASSED on D455, D555, D585S (Linux + Windows) and D457 (Jetson JP5).device_eachinstead of erroring.sw-dev/pytest-motion.py.🤖 Generated by AI