Repository navigation
advanced occ test: fix fill rate assertion to require post > modified - #15171
Merged
Merged
Conversation
… (drop old tolerance)
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the advanced on-chip calibration (OCC) live pytest to correct the fill-rate improvement assertion so it matches the intended requirement in the unit-test logic.
Changes:
- Remove the unused
FILL_RATE_CONVERGENCE_TOLERANCEconstant. - Update the fill-rate assertion to require
post_fill_rate > modified_fill_rate(fail on<=), rather than requiring an additional tolerance margin.
OhadMeir
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
advanced occ test: fix fill rate assertion to require post > modified