[Nir-Az]

Summary

Migrates the four unit-tests/live/hdr/ files to pytest:

• test-hdr-configurations.py → pytest-hdr-configurations.py — parametrized: 5 configs × 3 resolutions = 15 instances + 1 standalone test_disable_auto_hdr
• test-hdr-performance.py → pytest-hdr-performance.py — single function; removed count/count_frames globals in favor of a small FrameCounter class
• test-hdr-preset.py → pytest-hdr-preset.py — split into test_hdr_preset_manual + test_hdr_preset_auto
• hdr_helper.py — conservative refactor: kept module-level globals (am, sensor, pipe, batch_size); added setup_for_device(test_device) to populate them at test start. Function signatures unchanged. test.check(...) / test.closure(...) → pytest_check.check.* / log.info(...) (soft asserts so per-frame loop failures all surface)

Per-platform device selection

Legacy #test:device:jetson D457 / #test:device:!jetson D455 directives translated using rspy.pytest.device_helpers.is_jetson_platform:

pytestmark = [pytest.mark.device("D457" if is_jetson_platform() else "D455")]

Test plan (verified locally on D455)

• pytest-hdr-preset.py::test_hdr_preset_manual PASS (~12s)
• pytest-hdr-preset.py::test_hdr_preset_auto PASS (~12s)
• pytest-hdr-configurations.py::test_hdr_configurations[640x480-cfg1] PASS
• pytest-hdr-configurations.py::test_disable_auto_hdr PASS
• pytest-hdr-performance.py::test_hdr_performance PASS (~63s, 5 configs)
• Full nightly libci run (15 parametrized configs × 3 resolutions)

Nightly build
https://rsjenkins.realsenseai.com/job/LRS_libci_pipeline/15632/

🤖 Generated with Claude Code

[Nir-Az]

[rs-agentic bot] Automated review of PR #15036 — Migrate HDR tests to pytest

Overall the migration is clean and follows the pytest-infra skill guidelines well. Identified several BUGs and enhancements inline below. No Copilot reviewer assigned — proceeding with automated review.

[Nir-Az]

[rs-agentic bot] Additional review notes (non-inline)

---

1. 🔧 Guideline violation — git mv not used for test-hdr-configurations.py and test-hdr-performance.py

Per the pytest-infra skill step 2:

Rename with git mv: git mv test-foo.py pytest-foo.py (preserves history)

pytest-hdr-preset.py is correctly shown as a rename (git history preserved). However, pytest-hdr-configurations.py and pytest-hdr-performance.py appear as a delete + add pair, which loses the commit history for those files. Please amend the commit to use git mv so git log --follow works correctly for future debugging.

---

2. 🔧 Verify pytest_check is registered in rspy/pytest/plugins.py

The new files import from pytest_check import check. Per the pytest-infra skill:

When adding a pytest plugin to unit-tests/requirements.txt, you must also register it in rspy/pytest/plugins.py under REQUIRED_PYTEST_PLUGINS. … a missing plugin silently disables its CLI options … The registry makes the dependency explicit and fails loudly.

Please verify that pytest_check / pytest-check is already present in both requirements.txt and rspy/pytest/plugins.py. If not, add it to both.

---

3. ℹ️ Full nightly CI run still pending

The PR description notes the full 15-instance nightly run is unchecked. Recommend not merging until at least one complete libci nightly run passes on the target hardware (D455 non-Jetson, D457 Jetson), since the parametrized test_hdr_configurations matrix is the largest surface area change here.