Repository navigation
calib + image-quality: gate by --context, dedicate IQ depth test - #15015
Conversation
d3cb545 to
43ce87d
Compare
43ce87d to
bfd4e2a
Compare
| if not config.getoption("--timeout", default=None): | ||
| config.option.timeout = 200 | ||
| config.option.timeout_method = "thread" | ||
| config.option.timeout_method = "thread" if sys.platform == "win32" else "signal" |
There was a problem hiding this comment.
please add a comment explaining this
There was a problem hiding this comment.
reverted, as change is expected in subprocess PR
| config.option.timeout_method = "thread" | ||
| config.option.timeout_method = "thread" if sys.platform == "win32" else "signal" | ||
| # pytest-timeout reads func_only from ini only, not the CLI option attribute | ||
| config.inicfg["timeout_func_only"] = "true" |
There was a problem hiding this comment.
We want timeout for module and not func, is this the case?
There was a problem hiding this comment.
reverted, as change is expected in subprocess PR
There was a problem hiding this comment.
Not sure we will merge the subprocess PR..
There was a problem hiding this comment.
NP
Still leaving as reverted, can be handled in a separate PR as needed
| # the OpenCV S = (V - min) / V calculation; tight values false-fail) | ||
|
|
||
|
|
||
| def is_color_close(actual, expected): |
There was a problem hiding this comment.
Lets make sure the color test is valid and blue is detected as blue and if it was red it would fail
There was a problem hiding this comment.
added infra test checking different colors fail
There was a problem hiding this comment.
Now I understand why, since you verified it, I say lets remove the infra test and all hooks related
1 time verification that this mechanism works is enough IMO
440de62 to
25b2caf
Compare
|
|
||
| import sys, os, types | ||
|
|
||
| # CI runners don't ship pyrealsense2; iq_helper imports it at module top but |
There was a problem hiding this comment.
Please explain,
LibCI does have pyrealsense2, what happens here?
There was a problem hiding this comment.
NVM just saw it's the test, we can remove IMO if you trust the coloring validation (don't trust claude here..)
| # CI runners don't ship pyrealsense2; iq_helper imports it at module top but | ||
| # is_color_close itself only uses cv2+numpy, so a stub module is enough. | ||
| sys.modules.setdefault('pyrealsense2', types.ModuleType('pyrealsense2')) | ||
| sys.path.insert(0, os.path.join(os.path.dirname(__file__), '..', 'live', 'image-quality')) |
There was a problem hiding this comment.
This is a helper python why do we need this magic?
4a83517 to
cb84b9a
Compare
Tracked on: [RSDSO-21345]