Repository navigation
hdr option supported checked and test skipped if not supported - #14993
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates D400 live HDR tests to skip gracefully on devices that do not support the hdr_enabled option (RSDEV-8393), avoiding hard assertion failures on unsupported hardware.
Changes:
- Replace
assert depth_sensor and depth_sensor.supports(rs.option.hdr_enabled)withpytest.skip(...)in HDR sanity test. - Apply the same HDR-support skip behavior across multiple HDR long-test entry points and helpers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| unit-tests/live/d400/pytest-hdr-sanity.py | Skip HDR streaming sanity test when hdr_enabled is unsupported. |
| unit-tests/live/d400/pytest-hdr-long.py | Skip HDR config/streaming tests and helpers when hdr_enabled is unsupported. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Nir-Az
reviewed
Apr 30, 2026
Nir-Az
reviewed
Apr 30, 2026
| depth_sensor = dev.first_depth_sensor() | ||
|
|
||
| assert depth_sensor and depth_sensor.supports(rs.option.hdr_enabled) | ||
| if not (depth_sensor and depth_sensor.supports(rs.option.hdr_enabled)): |
Collaborator
There was a problem hiding this comment.
instead of repeating the check see Ohad PR which about to get merged about the new dependency plugin
#14987
He can further explain the usage
single check per file
remibettan
force-pushed
the
d401_hdr_test_fix
branch
from
May 3, 2026 12:56
1cf78e3 to
3722025
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked by: RSDEV-8393
Should be merged only after PR #14987 - update: MERGED