Skip to content

trigger device watcher on bind and unbind events - #14949

Merged
remibettan merged 3 commits into
realsenseai:developmentfrom
remibettan:dev_watcher_trigger_bind
Apr 20, 2026
Merged

remibettan merged 3 commits into
realsenseai:developmentfrom
remibettan:dev_watcher_trigger_bind

Conversation

@remibettan

Copy link
Copy Markdown
Contributor

Tracked by: RSDSO-20233

Copilot AI review requested due to automatic review settings April 19, 2026 11:01
Comment thread src/linux/udev-device-watcher.cpp Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Linux udev device watcher to treat bind/unbind udev actions as device-change events, ensuring device enumeration is triggered on hardware reset scenarios tracked by RSDSO-20233.

Changes:

  • Extend the udev action filter to include bind and unbind in addition to add and remove.
  • Update inline comments to document that hardware reset can surface as unbind/bind rather than remove/add.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

model = sysname;
os << model;
if( model != sysname )

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, new SKUs do not have intel what do we have with D401

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets change to realsense and check we get here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ll change it to RealSense, as we talked


const string udev_action = udev_device_get_action( udev_dev );
if( udev_action == "add" || udev_action == "remove" )
if( udev_action == "add" || udev_action == "remove" || udev_action == "bind" || udev_action == "unbind" )

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain?
Any rest can be added to reproduce before and pass after the fix?
Same issue on Ubuntu x86 ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

answered in the jira ticket

@remibettan
remibettan merged commit 1e97772 into realsenseai:development Apr 20, 2026
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants