Skip to content

Missed adding the new file to cmake - #14890

Merged
Nir-Az merged 2 commits into
developmentfrom
add-to-cmake
Apr 5, 2026
Merged

Nir-Az merged 2 commits into
developmentfrom
add-to-cmake

Conversation

@Nir-Az

@Nir-Az Nir-Az commented Mar 31, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings March 31, 2026 19:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the newly introduced firmware-update shared header to the common/ CMake source list so it’s picked up by CMake-generated projects that consume COMMON_SRC (e.g., viewer/tools).

Changes:

  • Added common/fw-update-common.h to COMMON_SRC in common/CMakeLists.txt.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AviaAv AviaAv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az
Nir-Az merged commit 7f712df into development Apr 5, 2026
57 of 58 checks passed
@Nir-Az
Nir-Az deleted the add-to-cmake branch August 6, 2026 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants